fix: Fix double space bug in frameworks metadata in user-agent header - #3413
Merged
Conversation
jterapin
approved these changes
Aug 5, 2026
jterapin
left a comment
jterapin
left a comment
Contributor
There was a problem hiding this comment.
Approved with the context of addressing feedbacks.
| @@ -1 +1 @@ | |||
| 3.254.0 | |||
| 3.254.1 | |||
Contributor
There was a problem hiding this comment.
Our automation will handle this when the change is merged in so please remove.
Contributor
Author
There was a problem hiding this comment.
Gotcha, reverted it back.
| @@ -1,5 +1,6 @@ | |||
| Unreleased Changes | |||
| ------------------ | |||
| * Issue - Fix double space bug in frameworks section of user-agent header. | |||
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| * Issue - Fix double space bug in frameworks section of user-agent header. | |
| * Issue - Fix a double space appearing in the frameworks section of the User-Agent header. |
Contributor
Author
There was a problem hiding this comment.
Changed as suggested.
Contributor
|
Please fix spec failures as shown below. |
richardwang1124
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.