Skip to content

fix: Fix double space bug in frameworks metadata in user-agent header #3413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sichanyoo merged 4 commits into from
Aug 6, 2026
+3 −2
Merged

fix: Fix double space bug in frameworks metadata in user-agent header #3413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
890d87a
Fix double space bug in frameworks metadata in user-agent header.
sichanyoo Aug 5, 2026
2b0ed7c
fix version lol
sichanyoo Aug 5, 2026
2e9225e
Address nits
sichanyoo Aug 5, 2026
96a77eb
Bump minimum core needed for S3.
sichanyoo Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build_tools/services.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class ServiceEnumerator
MINIMUM_CORE_VERSION = "3.254.0"

# Minimum `aws-sdk-core` version for new S3 gem builds
MINIMUM_CORE_VERSION_S3 = "3.254.0"
MINIMUM_CORE_VERSION_S3 = "3.254.1"

EVENTSTREAM_PLUGIN = "Aws::Plugins::EventStreamConfiguration"

Expand Down
1 change: 1 addition & 0 deletions gems/aws-sdk-core/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
Unreleased Changes
------------------
* Issue - Fix a double space appearing in the frameworks section of the User-Agent header.

3.254.0 (2026-07-09)
------------------
Expand Down
2 changes: 1 addition & 1 deletion gems/aws-sdk-core/lib/aws-sdk-core/plugins/user_agent.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ def framework_metadata

frameworks[match[:name]] = match[:version]
end
frameworks.map { |n, v| "lib/#{n}##{v}" }.join(' ')
frameworks.map { |n, v| "lib/#{n}##{v}" }.join(' ') unless frameworks.empty?
end

def metric_metadata
Expand Down