Skip to content

Closes #5449: Regression in scroll behavior of AJAX views with exposed filters#5453

Merged
joeparsons merged 1 commit intomainfrom
issue/5449
Apr 1, 2026
Merged

Closes #5449: Regression in scroll behavior of AJAX views with exposed filters#5453
joeparsons merged 1 commit intomainfrom
issue/5449

Conversation

@bberndt-uaz
Copy link
Copy Markdown
Contributor

@bberndt-uaz bberndt-uaz commented Mar 31, 2026

Description

Adds a patch to temporarily resolve this Drupal core issue:

Specifically, the patch reverts the changes from this Drupal core issue made to ajax.js in 10.6.x and 11.x:

This pull request should also be backported to Quickstart 2.x.

Related issues

How to test

  1. To observe the existing issue, visit the Calendar page on the demo site and observe the scrolling behavior when using the filters in the right sidebar.
  2. Also, visit the News Views page and observe the same behavior when using the category filter for the Grid View with Filter view.
  3. Now visit the Calendar page on the Tugboat review site and confirm that no scrolling occurs when you use the filters.
  4. Also, visit the News Views page on the Tugboat site and confirm that no scrolling occurs when you use the category dropdown for the Grid View with Filter view.
  5. Test other views with exposed forms as needed. The Finder views are not affected since Quickstart explicitly disables scrolling for those views.

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@bberndt-uaz bberndt-uaz self-assigned this Mar 31, 2026
@bberndt-uaz bberndt-uaz added backport-2.x Changes to be back-ported to the 2.x development branch 3.3.x only labels Mar 31, 2026
@bberndt-uaz bberndt-uaz linked an issue Mar 31, 2026 that may be closed by this pull request
@bberndt-uaz bberndt-uaz added the high priority Must get done for this milestone label Mar 31, 2026
@bberndt-uaz bberndt-uaz moved this from Todo to Needs review in 3.3.1 bug-fix patch release Mar 31, 2026
@bberndt-uaz bberndt-uaz marked this pull request as ready for review March 31, 2026 21:19
@bberndt-uaz bberndt-uaz requested review from a team as code owners March 31, 2026 21:19
@joeparsons joeparsons added Drupal Waiting on a fix from the Drupal community bug Something isn't working labels Mar 31, 2026
@tadean tadean self-requested a review March 31, 2026 21:46
Copy link
Copy Markdown
Contributor

@djcelaya djcelaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the patch locally and it seems to do the trick! I don't have a strong opinion on where the patch should be housed, however.

@tadean
Copy link
Copy Markdown
Contributor

tadean commented Apr 1, 2026

  - Applying patches for drupal/core
    ...
    https://gist.githubusercontent.com/bberndt-uaz/7183bc9aee173b19176955ba1cb178f9/raw/c7baa3a68d0325b1f459860831b075cd0819571d/3564586-11.x.patch (Views with exposed filter and ajax causes unexpected scroll position change (3564586))

Views exposed filters no longer seem to visually jump on use in my testing with this patch.

@github-project-automation github-project-automation bot moved this from Needs review to Ready to merge in 3.3.1 bug-fix patch release Apr 1, 2026
@joeparsons joeparsons merged commit de26e05 into main Apr 1, 2026
31 of 32 checks passed
@joeparsons joeparsons deleted the issue/5449 branch April 1, 2026 17:16
@github-project-automation github-project-automation bot moved this from Ready to merge to Done in 3.3.1 bug-fix patch release Apr 1, 2026
github-actions bot pushed a commit that referenced this pull request Apr 1, 2026
  This commit contains unresolved conflicts that need manual resolution.
  Original commit: de26e05
bberndt-uaz added a commit that referenced this pull request Apr 1, 2026
joeparsons added a commit that referenced this pull request Apr 2, 2026
…d filters (2.x backport of #5453) (#5455)

(cherry picked from commit de26e05)

---------

Co-authored-by: Brian Berndt <74572157+bberndt-uaz@users.noreply.github.com>
Co-authored-by: Joe Parsons <471936+joeparsons@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.3.x only backport-2.x Changes to be back-ported to the 2.x development branch bug Something isn't working Drupal Waiting on a fix from the Drupal community high priority Must get done for this milestone

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

Regression in scroll behavior of AJAX views with exposed filters

5 participants