fix: Welcome text fmt crash - #27
Merged
Merged
Conversation
The crash occurs because fmt::arg() is receiving temporary string values that are destroyed before the fmt::format() call completes. When player->GetGuildName() and player->GetPlayerName() return temporary strings, the fmt::arg() creates references to them, but they go out of scope immediately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
The previous PR didn't solve the crash
TLDR: rvalue was being passed that goes out of scope immediately
crash stack: https://gist.github.com/sogladev/7f7e238d673759d1dc4ce4474a303e7c
Issues Addressed:
SOURCE:
Tests Performed:
How to Test the Changes: