Skip to content

fix: Welcome text fmt crash #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Helias merged 1 commit into from
Apr 3, 2026
Merged

fix: Welcome text fmt crash #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/mod_starterguild.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,13 @@ void StarterGuild::addPlayerToGuild(Player* player)

// Inform the player they have joined the guild
std::string welcome_text = player->GetTeamId() == TEAM_ALLIANCE ? GUILD_WELCOME_TEXT_ALLIANCE : GUILD_WELCOME_TEXT_HORDE;
std::string guild_name = player->GetGuildName();
std::string player_name = player->GetPlayerName();

welcome_text = fmt::format(
fmt::runtime(welcome_text),
fmt::arg("GUILD", player->GetGuildName()),
fmt::arg("PLAYER", player->GetPlayerName())
fmt::arg("GUILD", guild_name),
fmt::arg("PLAYER", player_name)
);

ChatHandler(player->GetSession()).SendSysMessage(welcome_text);
Expand Down
Loading