Seed skills token needs issues: write for failure notifications - #58
Conversation
Review feedback (Codex, cli#53): scoping the skills App token to contents alone silently broke the failure-notification path — the same token drives gh issue list/comment/create on the skills repo, and those calls are swallowed by || true. permission-issues: write restores them.
There was a problem hiding this comment.
Pull request overview
This PR updates the seed template’s release workflow so the GitHub App token used for syncing skills can also successfully create/comment on issues for sync failure notifications in basecamp/skills.
Changes:
- Add
permission-issues: writeto theactions/create-github-app-tokenstep in the seed release workflow, enablinggh issue list/comment/createin the failure-notification step.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 109e886d1b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
#59) The workflow requests permission-contents and permission-issues, and the pinned create-github-app-token fails token creation outright when a requested permission is missing from the installation — a Contents-only App stops syncing entirely after #58. Document both permissions and the installation-update reapproval for existing Apps.
Follow-up to #53 closing the valid Codex P2: the seed template's skills App token is also the
GH_TOKENfor the failure-notification step (gh issue list/comment/createon basecamp/skills), and those calls are swallowed by|| true— so the contents-only scoping silently killed notifications. Addspermission-issues: write(a documented input on the pinned create-github-app-token v2.2.1, alongsidepermission-contents).