patch from https://github.com/kamilwylegala/cakephp2-php8/pull/83#15
Merged
patch from https://github.com/kamilwylegala/cakephp2-php8/pull/83#15
Conversation
There was a problem hiding this comment.
Copilot reviewed 1 out of 5 changed files in this pull request and generated 1 comment.
Files not reviewed (4)
- .github/workflows/phpcs.yml: Language not supported
- lib/Cake/Error/ErrorHandler.php: Language not supported
- lib/Cake/Model/Datasource/CakeSession.php: Language not supported
- lib/Cake/Model/Datasource/SessionHandlerAdapter.php: Language not supported
Comment on lines
+65
to
+66
| - Removed github action with php code sniffer. It's quite painful to work with. Need to migrate to something newer, that will affect code base as little as possible. | ||
|
|
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Owner
|
@coderabbitai summary |
✅ Actions performedSummary regeneration triggered. |
WalkthroughThis pull request includes the removal of the GitHub Actions workflow for PHP CodeSniffer (phpcs.yml), the addition of PHP 8.4 compatibility fixes and PHPCS action removal notes to the README, the removal of E_STRICT error handling in ErrorHandler, and the modification of the session handler configuration in CakeSession from the traditional array approach to a new object-oriented approach using SessionHandlerAdapter. Changes
Sequence Diagram(s)sequenceDiagram
participant CS as CakeSession
participant SA as SessionHandlerAdapter
participant CSH as CakeSessionHandler
CS->>SA: Configure session handler
SA->>CSH: Delegate open()/read()/write()/close()/destroy()/gc() operations
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.4 Compatibility Upgrade
This pull request incorporates patches from kamilwylegala/cakephp2-php8#83 to ensure compatibility with PHP 8.4.
Key Changes
Session Handling
SessionHandlerAdapterclass implementingSessionHandlerInterfaceto adapt CakePHP's session handlers to PHP's standard interfacesession_set_save_handler()calls to use the adapter object instead of arrays of callbacks, addressing PHP 8.4's deprecation of the array-style handler registrationError Handling
E_STRICTerror constant which has been deprecated in PHP 8.4ErrorHandler.phpBuild System
phpcs.yml)Implementation Details
The changes were applied using the following method:
wget https://github.com/kamilwylegala/cakephp2-php8/pull/83.patch patch -p1 < 83.patchThese modifications ensure that CakePHP 2.x applications can run smoothly on PHP 8.4 environments without deprecation warnings or errors.
Summary by CodeRabbit