fix: use correct release-please output key for root package dispatch - #15
Merged
Merged
Conversation
The release-please-action v4 outputs plain keys (e.g. 'tag_name') for
packages at root path '.', NOT path-prefixed keys ('.--tag_name').
The incorrect key caused dispatch-publish to always receive an empty
TAG, silently skipping the helm-publish and release-retag dispatches.
This prevented clean semver chart tags from being published to GHCR,
breaking Flux OCIRepository semver matching for stable overlays.
Co-Authored-By: kyle_hunter@bcit.ca <kyle_hunter@bcit.ca>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This was referenced May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
dispatch-publishjob inrelease-please.yamlwhich was using the wrong output key to read the release tag name, causinghelm-publish.yamlandrelease-retag.yamlto never be dispatched.Root cause: The
release-please-actionv4 source code shows that for packages at root path., outputs use plain keys (e.g.tag_name), NOT path-prefixed keys (.--tag_name). The workflow was usingsteps.rp.outputs['.--tag_name']which always resolved to empty, causing the dispatch guard to skip with the warning: "release-please reported a release but no tag_name output; skipping dispatch".Impact: No clean semver chart tags (e.g.
1.1.7) or Docker image tags were ever published for any release. Only CI-generated RC pre-release tags exist in GHCR. This breaks Flux OCIRepository semver matching for the stable overlay (cluster04), which requires clean release tags.Fix: Change
steps.rp.outputs['.--tag_name']→steps.rp.outputs['tag_name'].After merging: Manually trigger
helm-publish.yamlandrelease-retag.yamlvia workflow_dispatch withtag_name=v1.1.7to publish the missing clean tags for the current release.Review & Testing Checklist for Human
helm-publish.yamlwith inputtag_name=v1.1.7from the Actions tab to publish clean chart tag1.1.7release-retag.yamlwith inputtag_name=v1.1.7to publish clean Docker image tags1.1.7appears in GHCR atghcr.io/bcit-tlu/conversion-guide/charts/conversion-guideNotes
Confirmed via CI run logs that the v1.1.7 release dispatch job printed the empty-TAG warning and skipped both downstream workflows. The path-prefixed output format (
.--tag_name) is only used for non-root packages in monorepos — single-package repos at.get plain keys per the action'ssetPathOutputfunction.Link to Devin session: https://app.devin.ai/sessions/90351d31211c4d5fa00523df61bc4b90
Requested by: @kphunter