fix(cornerstone): TRAC-633 fix shipment info showing for cancelled orders

[mfaris9]

What?

Cause: Shipment information was being displayed on the Order Details page for orders in a Cancelled state in cornerstone. This was caused because shipping address was tied to if an item was assigned a shipping address.

Fix: Gate is_shipping with order.is_complete. is_complete is flips to true once the order reaches a fulfilled lifecycle state (Shipped, Completed). The theme already trusts this field at templates/pages/account/orders/details.html to gate the "Return this order" button, so reusing it here should be safe.

Requirements

• CHANGELOG.md entry added.

Tickets / Documentation

• https://linear.app/commerce/issue/LTRAC-648/shipment-info-shows-for-canceled-orders-in-cornerstone

Screenshots (if appropriate)

Attach images or add image links here.

[parthshahp]

• [1] CHANGELOG.md entry added.

Did you mean to put a 1 here? To check it off, you need to put an x. If you're not familiar with markdown syntax, there's a good guide by GitHub!

Also, like that implies, you should fill out an entry in the CHANGELOG.md file!

[parthshahp]

🍹 As an aside (and this is purely personal preference), I wouldn't put information like this in the PR itself:

Let me know if you'd still like me to loop in the Orders PM. I'm not sure whether Alex already reached out before I picked this up. I don't think it's strictly necessary; the fix resolves the issue as expected, and the "Ship to" message now only renders when the order is Shipped or Completed (screenshots attached covering the various states). Happy to reach out to Orders if you'd prefer, just let me know.

Also, I'd appreciate any feedback on the code changes or PR itself. This is my first one here and I want to make sure I'm following Commerce's conventions.

We often use the PR to go back and quickly get context on a specific change, and information like this may not be super relevant down the line. You could always put stuff like this in Slack (as a thread on your rfcr message) or as a comment in the PR rather than in the main description.

[bc-yevhenii-buliuk]

LGTM!