Merged
Conversation
I was developing these tests using BioCro version 3.2.0-3, but the online checks are using version 3.2.0, which produces different error messages. So I changed some tests so they don't check the content of error messages, which may differ with different BioCro versions.
| base_list[[element_name]] <- new_list[[element_name]] | ||
| } | ||
| base_list | ||
| } |
There was a problem hiding this comment.
modifyList does this, but it would also add new elements. Not sure if you want that.
Contributor
Author
There was a problem hiding this comment.
I didn't know about modifyList. Whenever combine_lists is called, the two lists have already been checked to make sure that the new list only has elements that already in the base list. So that wouldn't be an important difference.
I will replace combine_lists with modifyList.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an option to specify driver-specific initial values and parameters. It also addresses issue #14.