Use crazyflie-link and crazyradio through the crazyflie-lib re-exports#15
Merged
Conversation
crazyflie-lib now re-exports crazyflie-link (which re-exports crazyradio), so the exact versions it was built against are reachable as crazyflie_lib::crazyflie_link and no longer need to be direct dependencies kept manually in sync.
There was a problem hiding this comment.
Pull request overview
This PR updates the Rust crate in this repository to rely on crazyflie-lib’s re-exports of crazyflie-link (and transitively crazyradio), removing the need to keep direct dependency versions manually aligned.
Changes:
- Switch
rust/Cargo.tomlfrom a git-pinnedcrazyflie-libto the crates.io release0.8.1and drop directcrazyflie-link/crazyradiodependencies. - Update Rust code to reference
crazyflie-linkandcrazyradioviacrazyflie_lib::crazyflie_linkre-exports. - Refresh
rust/Cargo.lockto reflect the new dependency graph and resolved versions.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rust/src/link_context.rs | Updates type and API references to use crazyflie_lib re-exports for link/radio functionality. |
| rust/Cargo.toml | Removes direct crazyflie-link/crazyradio deps and moves crazyflie-lib to crates.io 0.8.1. |
| rust/Cargo.lock | Updates the lockfile to match the new dependency sources and resolved versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
crazyflie-lib 0.8.1 moved these commands to the new supervisor subsystem and deprecated the localization and platform methods, which fails our build under -D warnings. Call the supervisor methods internally instead; the Python API is unchanged and keeps exposing them in their current locations. Moving them under a supervisor subsystem in the Python API too is left to the pending supervisor subsystem PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crazyflie-lib now re-exports crazyflie-link (which re-exports crazyradio), so the exact versions it was built against are reachable as crazyflie_lib::crazyflie_link and no longer need to be direct dependencies kept manually in sync.