Bugfix/fix lead batch get returns deal item result - #470
Closed
Kuzm1ch-dev wants to merge 22 commits into
Closed
Conversation
…nnector-dev Feature/320 add imconnector dev
…groups-dev Add SonetGroup service
…ild-getTraversableList update getTraversableList in the services; add TaskEventFactory and r…
…enlines-dev Add imopenlines
Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Ship release 1.10.0
…handling of `scope` and `licence_family` fields in changelog. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
Signed-off-by: mesilov <mesilov.maxim@gmail.com>
…-portal Extend `Scope` and `PortalLicenseFamily` enums with new options, fix …
ship 1.10.1
8 tasks
Collaborator
|
Thanks for the fix and for catching the incorrect result type. I’m closing this PR because the branch is based on an old To keep the review focused and mergeable, I opened a fresh PR from current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lead Batch::list() yields DealItemResult instead of LeadItemResult