Skip to content

Fix lead batch item result type - #564

Merged
mesilov merged 1 commit into
v3-devfrom
bugfix/470-lead-batch-result
Jul 31, 2026
Merged

Fix lead batch item result type#564
mesilov merged 1 commit into
v3-devfrom
bugfix/470-lead-batch-result

Conversation

@mesilov

@mesilov mesilov commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator
Q A
Bug fix? yes
New feature? no
Deprecations? no
Issues N/A - supersedes #470; no separate issue exists
License MIT

Fixes Services\CRM\Lead\Service\Batch::list() so batched lead listing yields LeadItemResult objects instead of DealItemResult objects.

Supersedes #470. That PR has the correct intent, but its branch is based on an old v3 ancestor and now contains a large amount of unrelated history and conflicts. This PR reapplies only the intended lead batch result-type fix on top of current v3-dev, keeping the review focused and mergeable.

The PR also fixes a malformed phpunit.xml.dist testsuite block that prevented PHPUnit from parsing the current v3-dev config.

Test plan

  • make -s oa-schema-build BITRIX24_WEBHOOK=... - passed
  • make test-file path=tests/Unit/Services/CRM/Lead/Service/BatchTest.php - failed before the fix with DealItemResult, passed after the fix
  • make lint-cs-fixer - passed
  • make lint-rector - passed
  • make lint-phpstan - passed
  • make lint-deptrac - passed
  • make test-unit - passed, 1221 tests / 3336 assertions
  • make lint-all - passed

@mesilov mesilov added this to the 3.5.0 milestone Jul 31, 2026
@mesilov
mesilov marked this pull request as ready for review July 31, 2026 21:27
@mesilov
mesilov merged commit 8afbab0 into v3-dev Jul 31, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant