Fix lead batch item result type - #564
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Services\CRM\Lead\Service\Batch::list()so batched lead listing yieldsLeadItemResultobjects instead ofDealItemResultobjects.Supersedes #470. That PR has the correct intent, but its branch is based on an old
v3ancestor and now contains a large amount of unrelated history and conflicts. This PR reapplies only the intended lead batch result-type fix on top of currentv3-dev, keeping the review focused and mergeable.The PR also fixes a malformed
phpunit.xml.disttestsuite block that prevented PHPUnit from parsing the currentv3-devconfig.Test plan
make -s oa-schema-build BITRIX24_WEBHOOK=...- passedmake test-file path=tests/Unit/Services/CRM/Lead/Service/BatchTest.php- failed before the fix withDealItemResult, passed after the fixmake lint-cs-fixer- passedmake lint-rector- passedmake lint-phpstan- passedmake lint-deptrac- passedmake test-unit- passed, 1221 tests / 3336 assertionsmake lint-all- passed