Fix thumbnail dashboard card#3849
Merged
joaomariolago merged 3 commits intobluerobotics:masterfrom Mar 27, 2026
Merged
Conversation
…gation on controls Prevents the play/camera buttons from triggering navigation to the Video Manager page when the thumbnail is embedded in the dashboard. Closes bluerobotics#3848
The width prop was concatenated with 'px' unconditionally, producing invalid CSS 'autopx' when the dashboard passed 'auto'. Add a computed that only appends 'px' for purely numeric values, and pass '100%' from the dashboard so the thumbnail fills the card like it does on the Video Manager page.
…thin parent Constrain the thumbnail frame height to its parent and use object-fit contain so the full image is visible without overflow or cropping.
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In
parsedWidth, relying on/^\d+$/againstthis.widthassumes a string type; consider normalizingwidthto a number or usingNumber.isFinite(Number(this.width))so numeric prop values (or values with whitespace) are handled robustly. - Adding
@click.stop.preventon the entire.thumbnail-controlscontainer may unintentionally block default behavior for nested interactive elements; consider applying the modifiers on specific triggers (e.g., the thumbnail card itself) to avoid interfering with control interactions or accessibility.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `parsedWidth`, relying on `/^\d+$/` against `this.width` assumes a string type; consider normalizing `width` to a number or using `Number.isFinite(Number(this.width))` so numeric prop values (or values with whitespace) are handled robustly.
- Adding `@click.stop.prevent` on the entire `.thumbnail-controls` container may unintentionally block default behavior for nested interactive elements; consider applying the modifiers on specific triggers (e.g., the thumbnail card itself) to avoid interfering with control interactions or accessibility.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
2 tasks
joaomariolago
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3848
Summary by Sourcery
Fix sizing and interaction behavior of video thumbnail cards in the dashboard.
Bug Fixes: