Params: default TEMP2 to TMP119, log temperatures - #37
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
| TEMP2_SRC: 3, // Battery index | ||
| TEMP2_SRC_ID: 1, // Battery 1 |
There was a problem hiding this comment.
This is maybe not great default behaviour? I believe it should show up in SCALED_PRESSURE3 already (like the normal Celsius would), so this is only useful for people who are using both at once (which we can hopefully handle more nicely by implementing a dedicated TEMPERATURE MAVLink message, and if someone asks in the meantime we can tell them how to do the 'other source override' approach).
There was a problem hiding this comment.
I think the idea here is we are trying to find the most plug and play way for people to use Celsius 2 without needing to dig into their ardupilot config settings (which is needed if you want it to show up under SCALED_PRESSURE3)
But Willian can comment better on this
There was a problem hiding this comment.
I think the idea here is we are trying to find the most plug and play way for people to use Celsius 2 without needing to dig into their ardupilot config settings (which is needed if you want it to show up under SCALED_PRESSURE3)
correct. we were wondering if scaled_pressure3 would use the first useful temperature, but it is actually hardcoded to TEMP1, so we need this...
ES-Alexander
left a comment
ES-Alexander
left a comment
There was a problem hiding this comment.
Post some further investigation it seems the SCALED_PRESSURE3 pipeline only applies to the 1st instance of temperature sensor (determined by the driver configuration, not by what is actually connected), so won't automatically work for a setup with only a Celsius 2 configured as TEMP2_*.
I don't like the potential for confusion when setting this up, but if a firmware change is required we should fix things properly (via a new TEMPERATURE MAVLink message), and if that may take longer than the sensor release timeline I think the current battery temperature overriding approach is a manageable compromise - especially because we can set up a temporary alias in Cockpit for the Celsius 2, to make it easier to find.
We'll be working on the assumption that normal users aren't using an actual battery temperature sensor, but that seems acceptable for now.
3 participants
No description provided.