Skip to content

Params: default TEMP2 to TMP119, log temperatures #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Williangalvani merged 1 commit into from
Aug 5, 2026
Merged

Params: default TEMP2 to TMP119, log temperatures #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions params/ardupilot/ArduSub/4.7/navigator/Heavy BlueROV2.params
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
%include "../../hardware/boards/navigator.params"
%include "../../hardware/tmp119.params"
%include "../base.params"
%include "../heavy.params"

Expand Down
1 change: 1 addition & 0 deletions params/ardupilot/ArduSub/4.7/navigator/Standard BlueROV2.params
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
%include "../../hardware/boards/navigator.params"
%include "../../hardware/tmp119.params"
%include "../base.params"
%include "../standard.params"

Expand Down
5 changes: 5 additions & 0 deletions params/ardupilot/ArduSub/hardware/tmp119.params
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
TEMP2_TYPE: 10, // TMP TMP119
TEMP2_BUS: 6, // i2c-6
TEMP2_SRC: 3, // Battery index
TEMP2_SRC_ID: 1, // Battery 1
Comment on lines +3 to +4

@ES-Alexander ES-Alexander Aug 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is maybe not great default behaviour? I believe it should show up in SCALED_PRESSURE3 already (like the normal Celsius would), so this is only useful for people who are using both at once (which we can hopefully handle more nicely by implementing a dedicated TEMPERATURE MAVLink message, and if someone asks in the meantime we can tell them how to do the 'other source override' approach).

@zx100x100 zx100x100 Aug 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the idea here is we are trying to find the most plug and play way for people to use Celsius 2 without needing to dig into their ardupilot config settings (which is needed if you want it to show up under SCALED_PRESSURE3)

But Willian can comment better on this

@Williangalvani Williangalvani Aug 5, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the idea here is we are trying to find the most plug and play way for people to use Celsius 2 without needing to dig into their ardupilot config settings (which is needed if you want it to show up under SCALED_PRESSURE3)

correct. we were wondering if scaled_pressure3 would use the first useful temperature, but it is actually hardcoded to TEMP1, so we need this...

TEMP_LOG: 1, // log all temperature instances to binlogs
Loading