Replace string ":" with "." on filename of screenshotName#49
Open
wstagf wants to merge 3 commits into
Open
Conversation
felangel
reviewed
Apr 28, 2020
felangel
reviewed
Apr 29, 2020
felangel
left a comment
felangel
left a comment
There was a problem hiding this comment.
LGTM 👍
Would be nice to add a test for this change though.
felangel
approved these changes
Apr 29, 2020
Author
|
Added test case |
Author
|
@felangel what no merge? I have more actions in this fix? |
|
@jorgecoca are you able to merge? I don’t have permission. |
|
@dakrawczyk can you take a look? |
dakrawczyk
approved these changes
May 13, 2020
|
@JenniferJesuraj we may need another review on this PR before it's mergeable. |
JenniferJesuraj
approved these changes
May 14, 2020
|
@dakrawczyk looks like the ci isn't running. Do you have access to take a look? FYI @jorgecoca |
Hey @felangel ! yeah, I'm communicating with the team to get this resolved. Seems to be happening on our other repos as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix solve the issue 48 https://github.com/bmw-tech/ozzie.flutter/issues/48