Skip to content

Replace string ":" with "." on filename of screenshotName #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wstagf wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Replace string ":" with "." on filename of screenshotName #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8868585
Replace string ":" with "." on filename of screenshotName
wstagf Apr 23, 2020
9854313
Replace without 'new Reg'
wstagf Apr 29, 2020
ddc4956
test case takeScreenshot don`t contains character ":" on name
wstagf Apr 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/ozzie.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,8 @@ class Ozzie {

String get _groupFolderName => '$rootFolderName/$groupName';

String get _timestamp => DateTime.now().toIso8601String();
String get _timestamp =>
DateTime.now().toIso8601String().replaceAll(':', '.');

String _fileName(String screenshotName) => '$_timestamp-$screenshotName.png';

Expand Down
10 changes: 10 additions & 0 deletions test/ozzie_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,16 @@ void main() {
expect(true, resultFile.path.contains('rim.png'));
});

test('takeScreenshot generates PNGs don`t contains character ":" on name',
() async {
await ozzie.takeScreenshot('character');
final files =
Directory('$rootFolderName/$testGroupName').listSync().toList();
final resultFile =
files.where((f) => f is File).map((f) => f as File).first;
expect(false, resultFile.path.contains(':'));
});

group('HTML report generation', () {
test('not calling generateHtmlReport does not create index.html',
() async {
Expand Down