recording: node-editor tutorial sweep (cont.) — delete_and_select + context_menus + clipboard#27
Merged
Merged
Conversation
…in flow pulse
Fourth tutorial of the node-editor recording sweep. The legacy driver narrated
with single-string say()s, toggled set_user_control by hand, printed debug lines,
and ended on a soft if/else fallback ("the delete did not land"). Now:
- Voiced - 4 beats (chain / live pulse / select / delete-cascade), terse ASCII
captions decoupled from natural voice lines, paced by the wavs.
- Self-verifying - the click MUST select B (record_check_value selected=true) and
the Delete key MUST remove B AND cascade both links on its pins
(record_check_rendered=false on node_2, link_100, link_101), or the recording
aborts at teardown. dropped=0, ok=true.
- Highlight device - pulses both links with flow() to show the chain is live
before it is cut, on top of the editor's native selection highlight.
Dropped the manual set_user_control (with_node_editor_recording_app owns it) and
the stray prints; switched to ne_open. delete_and_select.rst gains the recording note.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ow pulse
Fifth tutorial of the node-editor recording sweep. The legacy driver narrated
with single-string say()s, toggled set_user_control by hand, printed four debug
lines, and ended on a soft if/else fallback ("the menu pick did not land"). Now:
- Voiced - 5 beats (live link / node menu / delete-cascade / background menu /
create), terse ASCII captions decoupled from natural voice lines, paced by the
wavs.
- Self-verifying - each right-click MUST open the matching menu (DEL_ITEM /
ADD_ITEM rendered), the node-menu pick MUST delete A AND cascade link_100
(both absent), and the background pick MUST spawn node_200 (rendered), or the
recording aborts at teardown. dropped=0, ok=true.
- Highlight device - opening flow pulse on the A->B link, so the node-menu delete
reads as cutting a live connection (same begin_delete path the delete tutorial
uses).
Dropped the manual set_user_control (with_node_editor_recording_app owns it) and
the stray prints; switched to ne_open. context_menus.rst gains the recording note.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR continues the node-editor tutorial recording sweep by upgrading the delete_and_select and context_menus recording drivers (and their tutorial docs) to the same voiced + self-verifying standard established in #26, using flow() pulses as a visual “live connection” highlight.
Changes:
- Reworks
record_delete_and_select.dasto assert selection and deletion outcomes viarecord_check_value/record_check_rendered, and adds link “live” pulses before cutting the chain. - Reworks
record_context_menus.dasto assert the correct context menus open, and that delete/create actions have the required effects, with a preludeflow()pulse. - Adds “recording is voiced and self-verifying” notes to the corresponding tutorial
.rstpages.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/integration/record_delete_and_select.das | Updates the delete+select recording driver to be voiced and assertion-based, with link pulses. |
| tests/integration/record_context_menus.das | Updates the context menu recording driver to be voiced and assertion-based, with a link pulse prelude. |
| doc/source/tutorials/delete_and_select.rst | Documents the new voiced/self-verifying recording behavior for the tutorial video. |
| doc/source/tutorials/context_menus.rst | Documents the new voiced/self-verifying recording behavior for the tutorial video. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+46
to
+49
| // ---- Beat 1: the chain ---- | ||
| record_check_rendered(app, T_B, true) | ||
| say(app, "A -> B -> C: two links", T_B, | ||
| [voice = "Here is a tiny chain - node A to B to C, joined by two links."]) |
Comment on lines
+56
to
+59
| // ---- Beat 1: the live link ---- | ||
| record_check_rendered(app, T_A, true) | ||
| let dwell = say_begin(app, "A -> B: a live link", T_A, | ||
| [voice = "A and B share a live link - we can pulse it to see data flow before we touch the menus."]) |
Click selects + focuses the canvas; real Ctrl+D / Ctrl+C / Ctrl+V chords fire partway into each voice line. imgui_key_hud overlays the keycap + modifier strip (keycap_fade_s=2.5 so the action key lingers through its line), so every chord is visible on screen as the voice names it. record_check_value(selected) plus record_check_rendered on the duplicate and the pasted node assert the edits land, or the recording aborts at teardown. RST gains a note that the recording app owns set_user_control(false) for the whole run and overlays the HUD. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
borisbat
changed the title
Comment on lines
+46
to
+49
| // ---- Beat 1: the chain ---- | ||
| record_check_rendered(app, T_B, true) | ||
| say(app, "A -> B -> C: two links", T_B, | ||
| [voice = "Here is a tiny chain - node A to B to C, joined by two links."]) |
Comment on lines
+56
to
+59
| // ---- Beat 1: the live link ---- | ||
| record_check_rendered(app, T_A, true) | ||
| let dwell = say_begin(app, "A -> B: a live link", T_A, | ||
| [voice = "A and B share a live link - we can pulse it to see data flow before we touch the menus."]) |
This was referenced Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues the node-editor tutorial recording sweep started in #26 (first_graph / connect_by_drag / create_by_drag, merged). Same bar: voiced (terse ASCII caption decoupled from natural voice), self-verifying (every interaction asserted via
record_check_rendered/record_check_value; a no-op aborts the recording at teardown), with theflow()data-flow pulse as the "highlight" device.Landing one tutorial at a time, each eyeball-approved before commit.
Included
record_check_value(selected=true)+record_check_rendered(false)on the node and both links). Replaces the legacy zero-verification driver.imgui_key_hudkeycap + modifier strip is overlaid, so each chord is visible on screen as the voice names it.record_check_value(selected)+record_check_renderedon the duplicate and the pasted node assert the edits land. Replaces the legacy zero-verification driver.(Remaining for a later PR: groups, styling, navigation.)
Per-tutorial cleanups
set_user_controltoggles (with_node_editor_recording_appowns it) and strayprint()debug lines.Notes
ne_flow(theflow_cmdrail used here) already landed on master in #26. The keycap HUD's per-actionkeycap_fade_s(so the action key lingers through its voice line) and the letter-keycode glyph mapping ride dasImgui borisbat/dasImgui#161 — but clipboard is CI-independent of it: the driver passeskeycap_fade_sin a JV (from_JVignores unknown fields on older dasImgui) and the committed.mp4was recorded with the fixed dasImgui, so it already shows the lingering[Ctrl][D]/[Ctrl][C]/[Ctrl][V]keycaps. The.apng/ wavs / manifest / sidecar are gitignored intermediates; only the.mp4is tracked.🤖 Generated with Claude Code