fix(cohere): add tool spans for chat tool calls#380
Merged
Abhijeet Prasad (AbhiPrasad) merged 2 commits intomainfrom May 1, 2026
Merged
fix(cohere): add tool spans for chat tool calls#380Abhijeet Prasad (AbhiPrasad) merged 2 commits intomainfrom
Abhijeet Prasad (AbhiPrasad) merged 2 commits intomainfrom
Conversation
Emit child TOOL spans for Cohere chat responses that include tool calls, covering both v1 and v2 response shapes. Rename the shared Cohere field accessor to document why tracing handles both dict and SDK model objects.\n\nAdd VCR-backed regression coverage for v1 and v2 tool-call responses.\n\nTest: nox -s "test_cohere(latest)" -- -k "tool_call_spans"
Andrew Kent (realark)
approved these changes
May 1, 2026
Merged
Abhijeet Prasad (AbhiPrasad)
added a commit
that referenced
this pull request
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emit child TOOL spans for Cohere chat responses that include tool calls, covering both v1 and v2 response shapes. Rename the shared Cohere field accessor to document why tracing handles both dict and SDK model objects.
resolves #377