feat(create): add build mode flags and fix workspace group resolution#287
Open
feat(create): add build mode flags and fix workspace group resolution#287
Conversation
theFong
force-pushed
the
fix/create-dynamic-workspace-group
branch
from
67ec7bd to
683b44a
Compare
…solution - Remove hardcoded "GCP" WorkspaceGroupID, resolve dynamically from instance type - Populate VMBuild by default so SSH setup works correctly - Add --mode flag (vm, k8s, container, compose) to select build type - Add --jupyter, --startup-script, --container-image, --compose-file flags - Match UI behavior: server determines mode from build field presence (vmBuild, customContainer, dockerCompose) - Mark old pkg/cmd/create as deprecated (gpucreate is the registered command) Tested: vm, container, and compose modes create successfully with SSH access. K8s mode sends correct config but requires a dev-plane fix for dashboard install.
theFong
force-pushed
the
fix/create-dynamic-workspace-group
branch
from
683b44a to
11efa89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"GCP"WorkspaceGroupID — now resolved dynamically viaGetAllInstanceTypesWithWorkspaceGroupsVMBuildby default so SSH setup works correctly (was causing "permission denied" onbrev create)--modeflag tobrev create:vm(default),k8s,container,compose--jupyter,--startup-script,--container-image,--compose-fileflagsvmBuild,customContainer,dockerCompose) — novmOnlyModeoronContaineroverridesTest plan
brev create test-vm— VM mode creates successfully, SSH worksbrev create test-container -m container --container-image nvidia/cuda:12.2.0-runtime-ubuntu22.04— container mode works, SSH on port 2222brev create test-compose -m compose --compose-file test-compose.yml— compose mode worksbrev create test-k8s -m k8s— sends correct k8s config (requires companion dev-plane fix for dashboard install)brev execworks on created instancesgo build ./...passesgo test ./pkg/cmd/create/... ./pkg/store/...Note: K8s mode requires brevdev/dev-plane#fix/k8s-dashboard-helm-repo to be deployed — the Kubernetes Dashboard Helm repo was retired Jan 2026.