feat(fm): cross-connection copy local↔remote (F5, increment C)#29
Merged
Conversation
Extends F5 beyond the same filesystem: copying between a local pane and a remote pane now routes each source file through the transfer engine (upload or download), so it shows progress and can be cancelled like any other transfer. - fm_registry: a pure `plan_transfer(source_fs, target_fs)` decides the route (DirectSameFs | Upload | Download | RemoteToRemote); the registry now also holds each pane's backend handle (`set_backend`/`backend_for`, dropped on close) so a local pane can upload through the remote pane's session. `others()` returns targets across filesystems. - browser: copy_or_move_to_other_pane dispatches on the plan — same fs keeps the direct backend copy/rename; local↔remote spawns an upload/download via a shared `spawn_transfer_with_backend` that mirrors the proven drag-and-drop transfer path. Existing targets are skipped (checked on whichever side owns the destination). - Honest deferrals (reported, never half-done): directories across connections, move across connections, and two-different-remote-hosts. Verified: cargo check -p warp 0/0; 248 sftp + 5 registry + 6 keynav tests green (2 new cross-connection routing tests + plan/backend units). No build triggered here. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the MC copy verb across connections: F5 between a local pane and a remote pane now routes each source file through the transfer engine (upload or download) — with progress and cancel, like any other transfer.
What lands
plan_transfer(source_fs, target_fs)— pure routing decision:DirectSameFs | Upload | Download | RemoteToRemote. Fully unit-tested.set_backend/backend_for, dropped on close) so a local pane can upload through the remote pane's session.others()returns targets across filesystems.copy_or_move_to_other_pane: same fs keeps the direct backend copy/rename (increment B); local↔remote spawns an upload/download via a sharedspawn_transfer_with_backendthat mirrors the proven drag-and-drop transfer path. Existing targets are skipped (checked on whichever side owns the destination).Honest deferrals (reported, never half-done): directories across connections, move across connections, and two-different-remote-hosts. These are the remainder of increment C.
Verified:
cargo check -p warp0 errors/0 warnings; 248 sftp + 5 registry + 6 keynav tests green — including 2 new synchronous routing tests (local→remote starts an upload; cross-connection move is deferred, source untouched) plus the plan/backend unit tests.🤖 Generated with Claude Code