feat: add proxy lease runner diagnostics#888
Closed
thymikee wants to merge 3 commits into
Closed
Conversation
|
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
This was referenced Jun 26, 2026
Member
Author
|
Coordinator update: this PR is the isolated runner diagnostics/docs slice. The reconciled end-to-end leasing stack is now in #890, which folds this work together with the canonical lease model, connect-proxy provider, and daemon session admission/expiry cleanup. Review #890 for integrated behavior; keep this PR for focused runner/docs review if needed. |
Member
Author
|
Closing as superseded by #890, which integrates the lease contract, proxy connect, session admission/expiry, and diagnostics work. Please continue review there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds diagnostics-only logical lease context to local/proxy iOS runner startup and busy-runner errors without weakening the on-disk runner file lease.
Updates CLI help and remote proxy docs to describe
connect proxy, lazy lease allocation onopen, five-minute inactivity expiry, and disconnect release. Runner language is scoped to local/proxy iOS while limrun/cloud remain provider interactor concerns.Also refactors the Worker D diagnostic context so core/daemon code uses a shared runner lease context type instead of importing the iOS runner lease module directly.
Related PR Context
This PR is the Worker D slice only. It is intended to stack after:
DeviceLeasemodel.connect proxyprofile/materialization and lazy proxy lease allocation.The integrated reconciled stack is now in #890. Review #890 for the end-to-end behavior and use this PR as the isolated runner/docs slice if reviewing changes independently.
Validation
Ran
pnpm format,pnpm exec vitest run src/platforms/ios/__tests__/runner-session.test.ts src/utils/__tests__/args.test.ts(186 tests passed), andpnpm typecheck.