feat: add proxy connect provider#889
Closed
thymikee wants to merge 3 commits into
Closed
Conversation
This was referenced Jun 26, 2026
Member
Author
|
Coordinator update: this PR is the isolated connect-proxy provider slice. The reconciled end-to-end leasing stack is now in #890, which folds this work together with the canonical lease model, daemon session admission/expiry cleanup, and runner diagnostics/docs. Review #890 for integrated behavior; keep this PR for focused proxy-provider review if needed. |
Member
Author
|
Closing as superseded by #890, which integrates the lease contract, proxy connect, session admission/expiry, and diagnostics work. Please continue review there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
agent-device connect proxy --daemon-base-url ...as a normal remote connection provider.This keeps proxy connection state in
RemoteConnectionState, generates non-secret remote config profiles, acquires a device-aware proxy lease beforeopenside effects, and propagates provider/client/device lease metadata through the existing client and daemon lease contracts.Plan 001 overlap is kept to the canonical open-ended lease model:
leaseProvider?: string, legacyprovidercompatibility, and generalDeviceLeasedevice binding.Related PR Context
This PR is the Worker B / Plan 002 slice only. It depends on Plan 001’s canonical
DeviceLeasemodel and is completed by Plan 003’s daemon session admission/expiry cleanup plus Plan 004/#888 runner diagnostics/docs.The integrated reconciled stack is now in #890. Review #890 for the end-to-end behavior and use this PR as the isolated
connect proxyimplementation slice if reviewing changes independently.Validation
pnpm formatpnpm exec vitest run src/__tests__/remote-connection.test.ts src/__tests__/cloud-connect-profile.test.ts src/utils/__tests__/args.test.tspnpm exec vitest run src/daemon/__tests__/request-router-open.test.tsnode --test test/integration/smoke-open-remote-config.test.tspnpm typecheckpnpm exec vitest run src/__tests__/remote-connection.test.ts src/__tests__/cloud-connect-profile.test.ts src/utils/__tests__/args.test.ts src/daemon/__tests__/request-router-open.test.ts