Skip to content

fix: update default ppa versions#24

Merged
rajannpatel merged 2 commits intocanonical:mainfrom
abehnia:fix-default-ppa-version
Feb 24, 2026
Merged

fix: update default ppa versions#24
rajannpatel merged 2 commits intocanonical:mainfrom
abehnia:fix-default-ppa-version

Conversation

@abehnia
Copy link
Contributor

@abehnia abehnia commented Feb 20, 2026

No description provided.

@abehnia abehnia requested a review from rajannpatel February 20, 2026 18:25
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update Line 78, where LANDSCAPE_VERSION is used, to reflect LANDSCAPE_PPA_NAME

Copy link
Contributor Author

@abehnia abehnia Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are two different scripts, did you want me to rename both to LANDSCAPE_PPA_NAME? otherwise, I think each one is using the right variable, they're just named differently in each.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake - yes - both should be using LANDSCAPE_PPA_NAME for consistency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed the comment

@rajannpatel rajannpatel merged commit 1df51a9 into canonical:main Feb 24, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants