Skip to content

fix: update default ppa versions #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rajannpatel merged 2 commits into from
Feb 24, 2026
Merged

fix: update default ppa versions #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a804533
fix: update default ppa versions
abehnia Feb 20, 2026
c63738d
change landscape-version -> landscape-ppa-name
abehnia Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions provisioning/cloud-init-quickstart-fips.yaml
View file
Open in desktop
Copy link
Collaborator

@rajannpatel rajannpatel Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update Line 78, where LANDSCAPE_VERSION is used, to reflect LANDSCAPE_PPA_NAME

Copy link
Contributor Author

@abehnia abehnia Feb 21, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are two different scripts, did you want me to rename both to LANDSCAPE_PPA_NAME? otherwise, I think each one is using the right variable, they're just named differently in each.

Copy link
Collaborator

@rajannpatel rajannpatel Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake - yes - both should be using LANDSCAPE_PPA_NAME for consistency.

Copy link
Contributor Author

@abehnia abehnia Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed the comment

Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@

# Landscape version:
# (self-hosted-25.10|self-hosted-24.04|self-hosted-beta|latest-stable)
{% set LANDSCAPE_VERSION = '24.04' %}
{% set LANDSCAPE_PPA_NAME = 'self-hosted-24.04' %}

# =========================
# END OF SETTING VARIABLES
Expand Down Expand Up @@ -75,7 +75,7 @@ package_reboot_if_required: true
apt:
sources:
source1:
source: 'ppa:landscape/{{ LANDSCAPE_VERSION }}'
source: 'ppa:landscape/{{ LANDSCAPE_PPA_NAME }}'

# `apt install`
packages:
Expand Down
2 changes: 1 addition & 1 deletion provisioning/cloud-init-quickstart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@

# Landscape version:
# (self-hosted-25.10|self-hosted-24.04|self-hosted-beta|latest-stable)
{% set LANDSCAPE_PPA_NAME = '24.04' %}
{% set LANDSCAPE_PPA_NAME = 'self-hosted-24.04' %}

# =========================
# END OF SETTING VARIABLES
Expand Down