chore(deps): migrate monorepo library builds from tsup to tsdown#2173
Merged
alexmatson-da merged 2 commits intoJul 21, 2026
Merged
Conversation
Contributor
|
I think something might've broken the wallet SDK's module (CI job failed) I recommend rebasing on latest main (we upgraded the repo's splice version recently). The steps to repro what CI is doing (requires local docker setup):
|
Swap tsup for tsdown across core/sdk packages with a shared tsdown.base.ts, including the RPC generator TypeScript client template. Adapt configs for rolldown (type-only re-exports, node/browser platforms, ledger-proto CJS sourcemaps, named exports where needed). Verified with clean full rebuild; no tsup leftovers remain. Fixes canton-network#1965 Signed-off-by: singhyash05 <yashsingh5609@gmail.com>
Parameter properties ran before super() under oxc → ReferenceError in e2e. Validate URL first, then super(), then assign fields. Signed-off-by: singhyash05 <yashsingh5609@gmail.com>
singhyash05
force-pushed
the
chore/1965-migrate-tsup-to-tsdown
branch
from
July 21, 2026 17:40
0545423 to
49b63f4
Compare
Contributor
Author
|
@alexmatson-da , problem was ParsedURL: tsdown (oxc) compiles the constructor's parameter properties into assignments that run before super(), which throws on a class extending URL. Rewrote it to validate the URL, call super(), then set the fields. Ran yarn nx playwright:e2e @canton-network/example-portfolio locally and all 25 passed. Rebased onto main too, thanks for the pointer. |
alexmatson-da
approved these changes
Jul 21, 2026
alexmatson-da
left a comment
Contributor
There was a problem hiding this comment.
looks great! thanks
mateuszpiatkowski-da
pushed a commit
that referenced
this pull request
Jul 22, 2026
* chore(deps): migrate monorepo library builds from tsup to tsdown Swap tsup for tsdown across core/sdk packages with a shared tsdown.base.ts, including the RPC generator TypeScript client template. Adapt configs for rolldown (type-only re-exports, node/browser platforms, ledger-proto CJS sourcemaps, named exports where needed). Verified with clean full rebuild; no tsup leftovers remain. Fixes #1965 Signed-off-by: singhyash05 <yashsingh5609@gmail.com> * Fix ParsedURL constructor for tsdown/oxc emit. Parameter properties ran before super() under oxc → ReferenceError in e2e. Validate URL first, then super(), then assign fields. Signed-off-by: singhyash05 <yashsingh5609@gmail.com> --------- Signed-off-by: singhyash05 <yashsingh5609@gmail.com> Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
fayi-da
added a commit
that referenced
this pull request
Jul 22, 2026
Leftover from #2173 Signed-off-by: Fayi Femi-Balogun <fayimora.femibalogun@digitalasset.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tsupwithtsdownfor library builds across ~35core/*andsdk/*packages.tsdown.base.ts(oldtsup.base.tsand per-packagetsup.config.tsfiles removed). Scripts anddevDependenciespoint attsdown@^0.22.9, including root andyarn.lock.provider-dapp,provider-ledger,rpc-transport,splice-providersigning-internal,signing-participant,wallet-test-utilsSOURCEMAP_BROKENspam)_package.json+tsdown.config.ts) soyarn generate:*copies a config that resolvestsdown.base.tsfromcore/<client>/, not from the template directory.export typeinledger-client,signing-lib, andsplice-client. Mixed default+named export packages setoutputOptions.exports: 'named'."type": "module"— that would break.commitlintrc.js.ParsedURLno longer uses constructor parameter properties. Undertsdown/oxc, those emittedthisbeforesuper()→ReferenceErrorin wallet-sdk e2e. Validate URL first, callsuper(), then assign fields.Fixes #1965
Test plan
yarn clean:all && yarn build:all) — 45/45rg tsup— no leftovers in source/configyarn workspace @canton-network/wallet-sdk build— emit hassuper(validateUrl(...))beforethis.ctxyarn nx playwright:e2e @canton-network/example-portfolio— 25 passed (localnet)