remove editor mentions - #44
Conversation
|
|
||
| If you provide a dataset AE where both AESEV and AESHOSP have empty values in a record, this rule will only flag a single error for that record, but it will display the empty values for both variables. | ||
|
|
||
| </details> |
There was a problem hiding this comment.
This belongs to previous tag is removed. Should we restore it?
| My test data dates are being treated as numbers or the engine is returning errors indicating that my dates cannot be parsed. | ||
| </summary> | ||
|
|
||
| When using Excel for data, one of the tradeoffs is that it tries to autoformat. If Excel recognizes a date, it will convert it to a numeric representation of the date and display it formatted. When the Rule Editor loads the date cell, it loads the number instead of the original text string date. You can confirm this by viewing the loaded test data section in the “Load Datasets” panel of the Rule Editor and checking if the date values are numbers instead of character strings. |
There was a problem hiding this comment.
This FAQ is still valid as excel dataset is supported with rules engine. Maybe we can just remove the mention of editor instead of the whole FAQ?
| [UI]-.->[Rule YAML Editor] | ||
| [UI]-.->[Rule Test] | ||
| [Rule YAML Editor]<->[cdisc-rules-engine-repo] | ||
| [Rule YAML Editor]<->[cdisc-open-rules-repo] |
There was a problem hiding this comment.
Do you think the name in the bracket also change? as I guess it is not an editor anymore.
There was a problem hiding this comment.
the name in the bracket references the image in the same directory. technically that image is dated as the whole editor app is removed from the architecture diagram.
There was a problem hiding this comment.
the whole diagram/this doc will need updating but that is outside the scope of this ticket
| ### Schema for Rule Schematic | ||
|
|
||
| Intellisense is informed by a schema in JSON format. The editor also uses it to provide suggestions. | ||
| Intellisense is informed by a schema in JSON format. |
There was a problem hiding this comment.
Is the mention of intellisense still valid as their is no rules editor anymore? Please let me know if I am misunderstanding something?
There was a problem hiding this comment.
https://code.visualstudio.com/docs/editing/intellisense intellisense is in IDE
RamilCDISC
left a comment
RamilCDISC
left a comment
There was a problem hiding this comment.
One last thing and we are good to merge.
| </summary> | ||
|
|
||
| When using Excel for data, one of the tradeoffs is that it tries to autoformat. If Excel recognizes a date, it will convert it to a numeric representation of the date and display it formatted. When the Rule Editor loads the date cell, it loads the number instead of the original text string date. You can confirm this by viewing the loaded test data section in the “Load Datasets” panel of the Rule Editor and checking if the date values are numbers instead of character strings. | ||
| When using Excel for data, one of the tradeoffs is that it tries to autoformat. If Excel recognizes a date, it will convert it to a numeric representation of the date and display it formatted. When the Rule Editor loads the date cell, it loads the number instead of the original text string date. |
There was a problem hiding this comment.
Do you think here we should say Rules Engine instead of Rules Editor now?
There was a problem hiding this comment.
missed that one--done
RamilCDISC
left a comment
RamilCDISC
left a comment
There was a problem hiding this comment.
The PR updates all the docs in rules engine to remove the references to rules editor.
All the updated docs has been validated to confirm:
- No mention of rule editor.
- Perseverance of documentation which concerned both rules engine and editor and ensured only rules editor reference is removed.
- All docs render properly.
3 participants
No description provided.