-
Notifications
You must be signed in to change notification settings - Fork 0
remove editor mentions #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
2755a1e
02cd79a
ebc228e
97d463c
d6300e2
c224d31
be91d6c
91f2ec2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,7 +43,7 @@ | |
| [UI]-.->[Rule List] | ||
| [UI]-.->[Rule YAML Editor] | ||
| [UI]-.->[Rule Test] | ||
| [Rule YAML Editor]<->[cdisc-rules-engine-repo] | ||
| [Rule YAML Editor]<->[cdisc-open-rules-repo] | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you think the name in the bracket also change? as I guess it is not an editor anymore.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the name in the bracket references the image in the same directory. technically that image is dated as the whole editor app is removed from the architecture diagram.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the whole diagram/this doc will need updating but that is outside the scope of this ticket |
||
|
|
||
| // API | ||
| [API]-.->[cdisc-rules-engine] | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -246,8 +246,8 @@ If you provide a dataset AE where both AESEV and AESHOSP have empty values in a | |
| My test data dates are being treated as numbers or the engine is returning errors indicating that my dates cannot be parsed. | ||
| </summary> | ||
|
|
||
| When using Excel for data, one of the tradeoffs is that it tries to autoformat. If Excel recognizes a date, it will convert it to a numeric representation of the date and display it formatted. When the Rule Editor loads the date cell, it loads the number instead of the original text string date. You can confirm this by viewing the loaded test data section in the “Load Datasets” panel of the Rule Editor and checking if the date values are numbers instead of character strings. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This FAQ is still valid as excel dataset is supported with rules engine. Maybe we can just remove the mention of editor instead of the whole FAQ? |
||
| When using Excel for data, one of the tradeoffs is that it tries to autoformat. If Excel recognizes a date, it will convert it to a numeric representation of the date and display it formatted. | ||
|
|
||
| To fix this issue, you can force transparency by [formatting the cells in your spreadsheet as "text"](https://support.microsoft.com/en-us/office/format-numbers-as-text-583160db-936b-4e52-bdff-6f1863518ba4). | ||
|
|
||
| </details> | ||
| </details> | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the mention of intellisense still valid as their is no rules editor anymore? Please let me know if I am misunderstanding something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://code.visualstudio.com/docs/editing/intellisense intellisense is in IDE