Skip to content

Refactored shellcheck workflow to be ci/lint.sh and lint.yml workflow - #1998

Merged
olehermanse merged 1 commit into
cfengine:masterfrom
craigcomstock:local-lint
Oct 23, 2025
Merged

Refactored shellcheck workflow to be ci/lint.sh and lint.yml workflow#1998
olehermanse merged 1 commit into
cfengine:masterfrom
craigcomstock:local-lint

Conversation

@craigcomstock

Copy link
Copy Markdown
Contributor

Ticket: none
Changelog: none

@craigcomstock
craigcomstock requested a review from larsewi October 23, 2025 10:30
Comment thread ci/lint.sh Outdated
@@ -0,0 +1,3 @@
grep -Erl '^(#!/(bin|usr/bin)/(env )?(sh|bash))' build-scripts/ | while read -r file; do

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@craigcomstock missing shebang?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh ha ha! ;) well I suppose it is though of course it will work generally.

I was going to add shellchecking more scripts so will add that and it will catch what you caught! :)

Also added ci/ and packaging/ but allowed those to fail.

Ticket: none
Changelog: none
@olehermanse
olehermanse merged commit 2c16b08 into cfengine:master Oct 23, 2025
1 check passed
@craigcomstock
craigcomstock deleted the local-lint branch October 23, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants