Skip to content

Refactored shellcheck workflow to be ci/lint.sh and lint.yml workflow #1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olehermanse merged 1 commit into from
Oct 23, 2025
Merged

Refactored shellcheck workflow to be ci/lint.sh and lint.yml workflow #1998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/workflows/shellcheck.yml → .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,4 @@ jobs:
run: sudo apt install shellcheck
- name: Lint sources with shellcheck
run: |
# Recursively find all shell scripts in the build-scripts directory with a shebang
grep -Erl '^(#!/(bin|usr/bin)/(env )?(sh|bash))' build-scripts/ | while read -r file; do
shellcheck --external-sources --source-path=build-scripts "$file"
done
./ci/lint.sh
11 changes: 11 additions & 0 deletions ci/lint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
#!/usr/bin/env bash
shellcheck_dirs() {
grep -Erl '^(#!/(bin|usr/bin)/(env )?(sh|bash))' "$1" | while read -r file; do
shellcheck --external-sources --source-path=build-scripts "$file"
done
}

shellcheck_dirs build-scripts/

# some dirs are "dirty" aka need some work so don't fail on those yet
shellcheck_dirs ci/ packaging/ || true