api(rust and jsonrpc): marknoticed_all_chats method to mark all chats as notices, including muted ones. #7709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notices, including muted ones. made for solving deltachat/deltachat-desktop#5891 (comment)
Simon-Laux
added a commit
to deltachat/deltachat-desktop
that referenced
this pull request
Jan 11, 2026
closes #5891 depends on: - core with chatmail/core#7709 - should be merged after #5922
Simon-Laux
added a commit
to deltachat/deltachat-desktop
that referenced
this pull request
Jan 11, 2026
closes #5891 depends on: - core with chatmail/core#7709 - should be merged after #5922
WofWca
reviewed
Jan 11, 2026
Collaborator
WofWca
left a comment
WofWca
left a comment
There was a problem hiding this comment.
Looks sensible overall, didn't test.
Simon-Laux
added a commit
to deltachat/deltachat-desktop
that referenced
this pull request
Jan 11, 2026
closes #5891 depends on: - core with chatmail/core#7709 - should be merged after #5922
Co-authored-by: WofWca <wofwca@protonmail.com>
iequidoo
reviewed
Jan 12, 2026
Hocuri
reviewed
Jan 14, 2026
method also mark chats with blocked contacts as noticed.
iequidoo
approved these changes
Jan 15, 2026
Collaborator
iequidoo
left a comment
iequidoo
left a comment
There was a problem hiding this comment.
LGTM, however, i didn't dive into what is wrong with the implicit start_chat_ephemeral_timers() calls
Hocuri
approved these changes
Jan 19, 2026
Simon-Laux
added a commit
to deltachat/deltachat-desktop
that referenced
this pull request
Jan 23, 2026
closes #5891 depends on: - core with chatmail/core#7709 - should be merged after #5922
Simon-Laux
added a commit
to deltachat/deltachat-desktop
that referenced
this pull request
Jan 26, 2026
closes #5891 depends on: - core with chatmail/core#7709 - should be merged after #5922
Simon-Laux
added a commit
to deltachat/deltachat-desktop
that referenced
this pull request
Jan 28, 2026
…5923) * fix: muted chats were not marked read when marking account as read closes #5891 depends on: - core with chatmail/core#7709 - should be merged after #5922 * rm unused import * fix: avoid undefined error in Object.keys --------- Co-authored-by: Nico de Haen <ndh@deltachat.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made for solving
deltachat/deltachat-desktop#5891 (comment)
will also be more efficient, because desktop currently loads all fresh messages to find out which chats to mark as noticed. https://github.com/deltachat/deltachat-desktop/blob/76d32bfc9364d53e1ffea40fcf4a60ad9a8482ee/packages/frontend/src/components/AccountListSidebar/AccountItem.tsx#L334
progress