refactor: don't use concat! in sql statements#7720
Merged
Simon-Laux merged 1 commit intomainfrom Jan 15, 2026
Merged
Conversation
4 tasks
Hocuri
approved these changes
Jan 15, 2026
Contributor
|
I'm curious what the motivation is? (descriptions are nice!) (this is not a request not to do this) |
Collaborator
|
Nothing particular, just having a uniform style across the codebase, see https://github.com/chatmail/core/blob/main/STYLE.md |
Member
Author
Right, I could have mentioned #7709 (comment) in the description. Only linked it in the other direction, forgot linking it here. |
Contributor
ah, thanks for that link! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.