Skip to content

Alignment with 1.108.2 version of VS Code#646

Open
RomanNikitenko wants to merge 5589 commits intoche-incubator:mainfrom
RomanNikitenko:alignment-with-upstream-1-108
Open

Alignment with 1.108.2 version of VS Code#646
RomanNikitenko wants to merge 5589 commits intoche-incubator:mainfrom
RomanNikitenko:alignment-with-upstream-1-108

Conversation

@RomanNikitenko
Copy link
Copy Markdown
Collaborator

@RomanNikitenko RomanNikitenko commented Feb 2, 2026

TODO

  • Test use cases related to removing axios
  • Test use cases detected within resolving conflicts to avoid a regression
  • Adapt Che-Code to work with the Dev Spaces Copilot Chat Integration extension:
    • Configure defaultChatAgent for devspaces-copilot-chat-integration: 199009d
    • Rebase rules: eb92105
  • Display Chat icon by default in the Command Center area: def3b8b
  • Do not use axios in the che-api/github-service: 6d11ed8
  • Fix PendingMigrationError: navigator is now a global in nodejs: 8b872b8
  • Fix multi line replace for rebase rules: 0aafbe8
  • Check if we need to revert Do not display Copilot-related items in the Command Center area #549
  • Check if we need to revert fix: Fix build of the ubi9-based assembly #650
  • Provide rebasing rule for 8409a01
  • Fix GitHub Pull Requests extension activation, see Alignment Che-Code with 1.108.x version of VS Code eclipse-che/che#23635 (comment), fix commit is: 8409a01
  • Check dependencies defined in the rebasing rules
  • Fix build of musl assembly
  • Update lock files
  • Use Node.js v22.22.0 for Dev image
  • Use Node.js v22.22.0 for ubi8/ubi9-based assemblies
  • Update base images for ubi8/ubi9/musl/dev/assembly
  • Add patch to the Dev
  • Update npm and node-gyp for the Dev
  • Adapt gulpfiles to upstream changes: c22ae74
  • Adapt undici-related changes to upstream: c1cb307
  • Adapt ajv-related changes to upstream eebf4d4
  • Adapt minimatch-related changes to upstream
    • code/test/smoke does not depend on minimatch anymore 18c8f00
    • code/test/mcp does not use minimatch anymore 90d41b8
    • Adapt minimatch-related changes in code/build to the upstream af6d4cf
  • Adapt path-to-regexp-related changes to upstream
    • Done: Adaptation is not required

What does this PR do?

What issues does this PR fix?

eclipse-che/che#23635

How to test this PR?

Test any functionality, I tested the following:

  • open a file
  • create a default terminal
  • create a terminal in a container
  • instal an extension
  • uninstall an extension
  • run a devfile command
  • run a command from the Command Palette
  • Git Clone flow from the Command Palette

I've tested the following use cases:

1. Released version of an extension should be installed

2. Chat icon

Screenshot 2026-04-14 at 14 16 18

3. Ability to manage extensions installation using a ConfigMap

4. Ansible-related use case

5. Default extensions should be installed when "Install from VSIX" is disabled (see #617)

  • Add default-extensions ConfigMap to your namespace:

    default-extensions ConfigMap
    kind: ConfigMap
    apiVersion: v1
    metadata:
      name: default-extensions
      labels:
        controller.devfile.io/mount-to-devworkspace: 'true'
        controller.devfile.io/watch-configmap: 'true'
      annotations:
         controller.devfile.io/mount-as: env
    data:
      DEFAULT_EXTENSIONS: '/tmp/atlassian.atlascode-3.0.10.vsix;/tmp/snowflake.snowflake-vsc-1.9.1.vsix'
    
  • Add vscode-editor-configurations ConfigMap to your namespace:

    vscode-editor-configurations ConfigMap
    kind: ConfigMap
    apiVersion: v1
    metadata:
      name: vscode-editor-configurations
      namespace: eclipse-che
      labels:
        app.kubernetes.io/part-of: che.eclipse.org
        app.kubernetes.io/component: workspaces-config
    data:
      configurations.json: |
        {
          "extensions.install-from-vsix-enabled": false
        }
    
  • Start workspace https://che-dogfooding.apps.che-dev.x6e0.p1.openshiftapps.com/#https://github.com/RomanNikitenko/web-nodejs-sample/tree/install-extensions-from-vsix?editor-image=quay.io/che-incubator-pull-requests/che-code:pr-646-amd64

  • Check: Extensions panel => ... => Install from VSIX action is absent

  • Check: Extensions panel => Atlassian, Snowflake and YAML extensions are installed as default extensions

6. Test starting a workspace and basic functionality for the following images

Image Workspace starts Link to start a workspace
udi
quay.io/devfile/universal-developer-image:ubi8-latest 🟢 click here
quay.io/devfile/universal-developer-image:ubi9-latest 🟢 click here
quay.io/devfile/universal-developer-image:ubi10-latest 🟢 click here
ubi-8
registry.access.redhat.com/ubi8-minimal:latest 🟢 click here
registry.access.redhat.com/ubi8-minimal:8.10 🟢 click here
registry.access.redhat.com/ubi8-minimal:8.9 🟢 click here
ubi-9
registry.access.redhat.com/ubi9-minimal:latest 🟢 click here
registry.access.redhat.com/ubi9-minimal:9.7 🟢 click here
registry.access.redhat.com/ubi9-minimal:9.6 🟢 click here
ubi-10
registry.access.redhat.com/ubi10-minimal:latest 🟢 click here
registry.access.redhat.com/ubi10-minimal:10.1 🟢 click here
registry.access.redhat.com/ubi10-minimal:10.0 🟢 click here

Does this PR contain changes that override default upstream Code-OSS behavior?

  • the PR contains changes in the code folder (you can skip it if your changes are placed in a che extension )
  • the corresponding items were added to the CHANGELOG.md file
  • rules for automatic git rebase were added to the .rebase folder

Tyriar and others added 30 commits January 2, 2026 02:21
Auto approve npm scripts from workspace package.json by default
npm scripts will be approved automatically with #285509. For npx we probably don't want to auto approve.
…ion.ps1

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Remove unnecessary auto approve rules
Editor GPU: Support rendering strikethrough
Use executable bit when completing commands in terminal suggest
Fix: Replace terminal tabbed view lifecycle hack with Event.once
Fix: Replace terminal view lifecycle hack with Event.once
…mmands

Fix auto-approve to suggest commands with flags when flags precede subcommand
@github-actions
Copy link
Copy Markdown

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Generated-by: Cursor AI
@RomanNikitenko RomanNikitenko force-pushed the alignment-with-upstream-1-108 branch from a74ab58 to 8b872b8 Compare March 30, 2026 17:56
@github-actions
Copy link
Copy Markdown

1 similar comment
@github-actions
Copy link
Copy Markdown

RomanNikitenko and others added 4 commits April 1, 2026 12:36
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Generated-by: Cursor AI
Protect Che-specific changes from commit 8409a01.

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Generated-by: Cursor AI
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Generated-by: Cursor AI
@RomanNikitenko RomanNikitenko force-pushed the alignment-with-upstream-1-108 branch from 159ccc6 to 0aafbe8 Compare April 1, 2026 12:37
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

Point extensionId and chatExtensionId to
redhat.devspaces-copilot-chat-integration to prevent the chat setup
flow from trying to install GitHub.copilot-chat which is not available
in the Open VSX registry. Grant the extension trusted auth access for
github and github-enterprise providers.

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Made-with: Cursor
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

RomanNikitenko and others added 2 commits April 3, 2026 17:50
Add rebasing rules for commit 199009d

Changes:
- Override product.json to set chatExtensionId and add trusted auth access
- Add replace rule for chatSetupController.ts to skip re-installation
- Update rebase.sh conflict resolution routing
- Document changes in CHANGELOG.md

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Add rebasing rule for commit a26b438 which adds the devfile
walkthrough extension to the builtInExtensions array. This extension
provides walkthrough guides for working with devfiles in Che.

Changes:
- Add devfile.vscode-devfile extension to .rebase/add/code/product.json
- Update CHANGELOG.md to document the change

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

1 similar comment
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2026

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

@github-actions
Copy link
Copy Markdown

@RomanNikitenko RomanNikitenko marked this pull request as ready for review April 14, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.