Testplan and toggle coverage improvements#149
Open
jan-malek wants to merge 17 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes tests added by Coverage improvements #132 into the testplan
Extends waivers for:
I3CCSR.sv: Waives remainingfield_combosignals and parts of readback_array that weren't investigated yetrecovery_executor.sv: Adds more waiversrecovery_handler.sv: Adds more waiverscsri.sv,controller.sv,configuration.sv: Copy existing CSR interface waivers from other modulesAdds waivers for new modules:
tti.sv,ccc.sv,ccc_entdaa.sv,descriptor_tx.sv,descriptor_rx.sv,i3c_target_fsm.sv,ibi.sv,descriptor_ibi.sv,recovery_transmitter.sv,recovery_receiver.sv,queues.sv,read_queue.sv,write_queue.sv,bus_tx.sv,bus_tx_flow.sv,bus_rx_flow.sv,bus_timers.sv,stable_high_detector.sv,edge_detector.sv,axi_adapter.sv,i3c_axi_sub_wr.sv,i3c_axi_sub_rd.sv,i3c_axi_sub_arb.sv,i3c_axi_sub.svAdds tests to improve coverage:
test_ccc_entdaa_parity: To cover the NACK flow of the ccc_entdaa FSM.test_i3c_target_read_long: To cover upper bits of the TX descriptor (just like whattest_i3c_target_write_255does to the RX descriptor)test_i3c_target_ibi_retry_finite: Tests handling of different values of the IBI retry counter (so far only 7 = infinite was tested)test_i3c_target_ibi_hold_time: Tests if the IBI module respects the T_HD_DAT timing (which also covers the hold timer)test_i3c_target_ibi_data_long: To cover upper bits of the IBI descriptor (just like whattest_i3c_target_write_255does to the RX descriptor)Changes existing tests to improve coverage:
test_payload_available: Adds tactical CSR reads to cover more ranges in I3CCSR readback_array. Also fixes a test logic issue.test_ccc_rstact: Fixed indentation to have an assertion apply to all loop iterations.RTL changes:
ccc.sv: Removed unused signali3c_target_fsm.sv: Removed unused signals. Renamed a misnamed signal.ibi.sv: Fixed logic of the retry counter FF to actually limit the number of retries.width_converter_8toN.sv: Changed a constant signal into a localparam.bus_tx_flow.sv: Make a bit counter one bit narrower (it only counts to 7)axi_adapter.sv: Remove unused signal.Adds waiver reasons for remaining CSR interface signals that didn't have a specific reason described yet. They were either:
readback_arraythat map to an already waived CSR fieldAdds waivers from
waivers.yamlintoexclusion.yamland removes the formerTranslates the legacy
exclusion.yamlinto the new format