I3C configuration.sv Coverage Gaps #199#192
Open
navadiya-cpu wants to merge 7 commits into
Open
Conversation
Signed-off-by: Ankita Navadiya <navadiya@google.com>
moidx
previously approved these changes
Apr 21, 2026
mkj121
previously approved these changes
Apr 22, 2026
mkj121
left a comment
mkj121
left a comment
Collaborator
There was a problem hiding this comment.
Possible tidy up in one comment
| f_ena, f_force, f_sts = fields | ||
|
|
||
| # Ensure clean state: disable all interrupts and clear all status bits | ||
| await tb.write_csr(tb.reg_map.I3C_EC.TTI.INTERRUPT_ENABLE.base_addr, int2dword(0x00000000), 4) |
Collaborator
There was a problem hiding this comment.
For consistency should all the interrupt force bits be cleared at this point too?
Collaborator
Author
There was a problem hiding this comment.
Ensure all interrupt force bits are cleared at the end for a "clean state," preventing any impact on other tests.
Signed-off-by: Ankita Navadiya <navadiya@google.com>
Signed-off-by: Ankita Navadiya <navadiya@google.com>
Signed-off-by: Ankita Navadiya <navadiya@google.com>
Signed-off-by: Ankita Navadiya <navadiya@google.com>
Collaborator
|
Hi @navadiya-cpu, Thanks for opening the PR. Could you please explain the rationale behind using force/release here? As you wrote in the comment - those fields are either tied-off or masked. Shouldn't we simply waive this part? |
Collaborator
Author
|
Hi Robert,
I believe you're referring to test_recovery_coverage.py at line 110:
chipsalliance/caliptra-embargoed#198. While
waiving might be an option instead of tied-off or masking the signal, that
decision ultimately rests with the designer, so I cannot weigh in on it.
Regarding this issue,
chipsalliance/caliptra-embargoed#199, I didn't
include comments about the tied-off or masked state since the scenario
itself already encompasses those details. Please share your thoughts.
…On Tue, May 5, 2026 at 10:39 AM Robert Szczepański ***@***.***> wrote:
*robertszczepanski* left a comment (chipsalliance/i3c-core#192)
<#192 (comment)>
Hi @navadiya-cpu <https://github.com/navadiya-cpu>,
Thanks for opening the PR.
Could you please explain the rationale behind using force/release here? As
you wrote in the comment - those fields are either tied-off or masked.
Shouldn't we simply waive this part?
—
Reply to this email directly, view it on GitHub
<#192 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/B5BHI2APUZE62NXANENT2JT4ZIRLZAVCNFSM6AAAAACYBJQM26VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DGOBRGYYDMNJSHE>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I3C configuration.sv Coverage Gaps #199::
https://github.com/chipsalliance/caliptra-embargoed/issues/199#issuecomment-4246370051
Here are some scenarios I developed based on coverage gaps: