Issue #198#202
Open
navadiya-cpu wants to merge 7 commits into
Open
Conversation
Signed-off-by: Ankita Navadiya <navadiya@google.com>
Signed-off-by: Ankita Navadiya <navadiya@google.com>
Signed-off-by: Ankita Navadiya <navadiya@google.com>
Signed-off-by: Ankita Navadiya <navadiya@google.com>
Signed-off-by: Ankita Navadiya <navadiya@google.com>
Collaborator
|
@navadiya-cpu can you merge this now? When you merge this, can you select "Squash and Merge" so a single logic commit is created for this PR? and make sure to write a clean commit message, instead of accepting the defaults. |
navadiya-cpu
dismissed
mkj121’s stale review
The merge-base changed after approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have developed test cases for issue #198 (https://github.com/chipsalliance/caliptra-embargoed/issues/198) that successfully cover all signals and ensure toggle coverage.
Test name: test_recovery_coverage.py