update entry file & README to fix deprecations#32
Open
jeremyeaton89 wants to merge 3 commits intochirag04:masterfrom
Open
update entry file & README to fix deprecations#32jeremyeaton89 wants to merge 3 commits intochirag04:masterfrom
jeremyeaton89 wants to merge 3 commits intochirag04:masterfrom
Conversation
chirag04
reviewed
Oct 10, 2017
ToolTip.ios.js
Outdated
| NativeModules, | ||
| findNodeHandle, | ||
| } = require('react-native'); | ||
| var PropTypes = require('prop-types'); |
Owner
There was a problem hiding this comment.
can you add this to package.json?
Also it would be awesome to have those vars as const/let.
Author
|
any chance this can be merged? happy new year! :) |
Owner
|
Is this still required? Will need rebase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just wanted to get this working out of the box for React 16. Took a look at getting the examples to work, but solution seemed non trivial. Hopefully this works for now!