feat: adopt existing agent-shell sessions instead of always creating#6
Open
Lenbok wants to merge 2 commits intocmacrae:mainfrom
Open
feat: adopt existing agent-shell sessions instead of always creating#6Lenbok wants to merge 2 commits intocmacrae:mainfrom
Lenbok wants to merge 2 commits intocmacrae:mainfrom
Conversation
…new ones When toggling the sidebar, check for existing agent-shell buffers in the current project that aren't registered with the sidebar and adopt them rather than creating new sessions. This allows users to manually create agent-shell sessions and have the sidebar reuse them. - Add agent-shell-sidebar--find-unregistered-buffers to search for unregistered agent-shell buffers by project root - Add agent-shell-sidebar--adopt-existing-session to register and mark an existing buffer as a sidebar session - Update agent-shell-sidebar--create-and-show-sidebar to try adoption before creating new sessions
- Fix agent-shell-sidebar--get-window to find actual sidebar window when buffer is shown in both sidebar and normal windows - Remove window-size-fixed to avoid issues with buffer-local variable affecting all windows showing the buffer - Add no-other-window parameter to make sidebar invisible to other-window when locked - Update agent-shell-sidebar-locked docstring to reflect actual behavior - Fix agent-shell-sidebar--display-buffer to avoid duplicate windows when converting sole window to sidebar - Prevent 'same side but no common parent' errors by properly handling non-sidebar windows before creating sidebar
Author
|
Added extra fixes related to problems when you intermingle use of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When toggling the sidebar, check for existing agent-shell buffers in the current project that aren't registered with the sidebar and adopt them rather than creating new sessions. This allows users to manually create agent-shell sessions and have the sidebar reuse them.