Fix apple-touch-icon: use a square icon instead of the wide OG banner - #18
Conversation
All five pages (landing, docs layout, playground, theme-builder, demo) pointed <link rel=apple-touch-icon> at assets/og-banner.png, a 1200x630 social-preview banner. iOS/home-screen and other consumers expect a square icon, so the wide banner rendered squished/cropped and didn't match the chevron logo used as the actual favicon everywhere. - site/assets/app-icon.svg: a square (192x192, rounded) icon with the same gradient chevron mark, on the site's dark background - build-site.mjs rasterizes it to a 180x180 PNG at build time (alongside the existing og-banner rasterization) and both the generated docs layout and the four static pages now reference assets/app-icon.png instead of assets/og-banner.png
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe build now creates a 180x180 PNG from the SVG app icon, and site pages reference it as their Apple touch icon instead of the OG banner. ChangesApple touch icon asset update
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install timed out. The project may have too many dependencies for the sandbox. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
forge-select | 0ece751 | Commit Preview URL Branch Preview URL |
Jul 21 2026, 02:21 PM |



Summary
Branch was resynced to the latest
main(v0.6.0 — dev is already fully merged in, so there was nothing left to bring over there); this PR is the actual fix requested for the broken favicon.<link rel="apple-touch-icon">on all five pages (landing, generated docs layout, playground, theme-builder, demo) pointed atassets/og-banner.png— the 1200×630 wide social-preview banner. iOS/home-screen and other icon consumers expect a square image, so the banner rendered squished/cropped instead of the chevron logo used everywhere else as the real favicon.site/assets/app-icon.svg— a square (192×192, rounded corners) icon reusing the same gradient chevron mark on the site's dark background.scripts/build-site.mjsnow rasterizes it to a 180×180 PNG at build time (same pattern as the existing OG-banner rasterization), and all fiveapple-touch-iconreferences now point toassets/app-icon.pnginstead ofassets/og-banner.png.rel="icon", the inline gradient-chevron SVG data URI) was already correct on every page — onlyapple-touch-iconwas wrong.Test plan
npm run typecheck,npm run lint,npm run format:check,npm test(142/142) all pass.npm run build:sitethennode scripts/check-site.mjs— all generated links/assets resolve; confirmedapp-icon.pngrasterizes to exactly 180×180./,/docs/,/playground/,/theme-builder/,/demo/): each resolvesapple-touch-icontoassets/app-icon.png(200, correct bytes),rel="icon"unchanged, zero console errors.Generated by Claude Code
Summary by CodeRabbit