Skip to content

Fix apple-touch-icon: use a square icon instead of the wide OG banner #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmm-cmm merged 1 commit into from
Jul 21, 2026
Merged

Fix apple-touch-icon: use a square icon instead of the wide OG banner #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion demo/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
<meta name="twitter:description" content="Interactive showcase of every Forge Select feature: single/multi select, tags, drag-and-drop tag reordering, option groups, tree select, custom templates, rich items, virtual scrolling, i18n, and events.">
<meta name="twitter:image" content="https://forgeselect.konexforge.com/assets/og-banner.png">
<link rel="icon" href="data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 24 28'><defs><linearGradient id='g' x1='0' y1='0' x2='1' y2='1'><stop offset='0' stop-color='%2384cc16'/><stop offset='0.5' stop-color='%2322c55e'/><stop offset='1' stop-color='%2315803d'/></linearGradient></defs><path d='M4 3L12 9L20 3' stroke='url(%23g)' stroke-width='3' stroke-linecap='round' stroke-linejoin='round' fill='none'/><path d='M4 12L12 18L20 12' stroke='url(%23g)' stroke-width='3' stroke-linecap='round' stroke-linejoin='round' fill='none'/><path d='M4 21L12 27L20 21' stroke='url(%23g)' stroke-width='3' stroke-linecap='round' stroke-linejoin='round' fill='none'/></svg>">
<link rel="apple-touch-icon" href="../assets/og-banner.png">
<link rel="apple-touch-icon" href="../assets/app-icon.png">
<link rel="stylesheet" href="../styles/forge-select.css">
<link rel="stylesheet" href="../assets/site.css">
<script type="application/ld+json">
Expand Down
9 changes: 8 additions & 1 deletion scripts/build-site.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ function layout({ title, description, canonicalPath, jsonLdBlocks, active, conte
<meta name="twitter:description" content="${description}">
<meta name="twitter:image" content="${SITE_URL}assets/og-banner.png">
<link rel="icon" href="data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 24 28'><defs><linearGradient id='g' x1='0' y1='0' x2='1' y2='1'><stop offset='0' stop-color='%2384cc16'/><stop offset='0.5' stop-color='%2322c55e'/><stop offset='1' stop-color='%2315803d'/></linearGradient></defs><path d='M4 3L12 9L20 3' stroke='url(%23g)' stroke-width='3' stroke-linecap='round' stroke-linejoin='round' fill='none'/><path d='M4 12L12 18L20 12' stroke='url(%23g)' stroke-width='3' stroke-linecap='round' stroke-linejoin='round' fill='none'/><path d='M4 21L12 27L20 21' stroke='url(%23g)' stroke-width='3' stroke-linecap='round' stroke-linejoin='round' fill='none'/></svg>">
<link rel="apple-touch-icon" href="../assets/og-banner.png">
<link rel="apple-touch-icon" href="../assets/app-icon.png">
<link rel="stylesheet" href="../assets/site.css">
<link rel="stylesheet" href="../assets/hljs-light.css" media="(prefers-color-scheme: light)">
<link rel="stylesheet" href="../assets/hljs-dark.css" media="(prefers-color-scheme: dark)">
Expand Down Expand Up @@ -296,6 +296,13 @@ async function main() {
// LinkedIn render svg og:image/twitter:image inconsistently, so a real
// PNG is required for a reliable social preview.
await sharp(path.join(out, "assets/og-banner.svg")).png().toFile(path.join(out, "assets/og-banner.png"));
// Separate square app icon for apple-touch-icon — the wide 1200x630
// og-banner is the wrong aspect ratio for a home-screen icon and gets
// squished/cropped on iOS.
await sharp(path.join(out, "assets/app-icon.svg"))
.resize(180, 180)
.png()
.toFile(path.join(out, "assets/app-icon.png"));
await cp(path.join(root, "site/playground"), path.join(out, "playground"), { recursive: true });
await cp(path.join(root, "site/theme-builder"), path.join(out, "theme-builder"), { recursive: true });
await cp(path.join(root, "demo"), path.join(out, "demo"), { recursive: true });
Expand Down
15 changes: 15 additions & 0 deletions site/assets/app-icon.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion site/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
<meta name="twitter:description" content="Forge Select is a zero-dependency, accessible, high-performance select component with rich items, virtual scrolling, tags, AJAX, tree select, drag-and-drop tag ordering, and a plugin architecture.">
<meta name="twitter:image" content="https://forgeselect.konexforge.com/assets/og-banner.png">
<link rel="icon" href="data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 24 28'><defs><linearGradient id='g' x1='0' y1='0' x2='1' y2='1'><stop offset='0' stop-color='%2384cc16'/><stop offset='0.5' stop-color='%2322c55e'/><stop offset='1' stop-color='%2315803d'/></linearGradient></defs><path d='M4 3L12 9L20 3' stroke='url(%23g)' stroke-width='3' stroke-linecap='round' stroke-linejoin='round' fill='none'/><path d='M4 12L12 18L20 12' stroke='url(%23g)' stroke-width='3' stroke-linecap='round' stroke-linejoin='round' fill='none'/><path d='M4 21L12 27L20 21' stroke='url(%23g)' stroke-width='3' stroke-linecap='round' stroke-linejoin='round' fill='none'/></svg>">
<link rel="apple-touch-icon" href="./assets/og-banner.png">
<link rel="apple-touch-icon" href="./assets/app-icon.png">
<link rel="stylesheet" href="./assets/site.css">
<script type="application/ld+json">
{
Expand Down
2 changes: 1 addition & 1 deletion site/playground/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
<meta name="twitter:description" content="Write and run Forge Select code live in the browser with ready-made presets for every major feature — no install required.">
<meta name="twitter:image" content="https://forgeselect.konexforge.com/assets/og-banner.png">
<link rel="icon" href="data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 24 28'><defs><linearGradient id='g' x1='0' y1='0' x2='1' y2='1'><stop offset='0' stop-color='%2384cc16'/><stop offset='0.5' stop-color='%2322c55e'/><stop offset='1' stop-color='%2315803d'/></linearGradient></defs><path d='M4 3L12 9L20 3' stroke='url(%23g)' stroke-width='3' stroke-linecap='round' stroke-linejoin='round' fill='none'/><path d='M4 12L12 18L20 12' stroke='url(%23g)' stroke-width='3' stroke-linecap='round' stroke-linejoin='round' fill='none'/><path d='M4 21L12 27L20 21' stroke='url(%23g)' stroke-width='3' stroke-linecap='round' stroke-linejoin='round' fill='none'/></svg>">
<link rel="apple-touch-icon" href="../assets/og-banner.png">
<link rel="apple-touch-icon" href="../assets/app-icon.png">
<link rel="stylesheet" href="../styles/forge-select.css">
<link rel="stylesheet" href="../assets/site.css">
<script type="application/ld+json">
Expand Down
2 changes: 1 addition & 1 deletion site/theme-builder/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
<meta name="twitter:description" content="Customize every Forge Select CSS variable live and copy the generated theme CSS — no build step required.">
<meta name="twitter:image" content="https://forgeselect.konexforge.com/assets/og-banner.png">
<link rel="icon" href="data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 24 28'><defs><linearGradient id='g' x1='0' y1='0' x2='1' y2='1'><stop offset='0' stop-color='%2384cc16'/><stop offset='0.5' stop-color='%2322c55e'/><stop offset='1' stop-color='%2315803d'/></linearGradient></defs><path d='M4 3L12 9L20 3' stroke='url(%23g)' stroke-width='3' stroke-linecap='round' stroke-linejoin='round' fill='none'/><path d='M4 12L12 18L20 12' stroke='url(%23g)' stroke-width='3' stroke-linecap='round' stroke-linejoin='round' fill='none'/><path d='M4 21L12 27L20 21' stroke='url(%23g)' stroke-width='3' stroke-linecap='round' stroke-linejoin='round' fill='none'/></svg>">
<link rel="apple-touch-icon" href="../assets/og-banner.png">
<link rel="apple-touch-icon" href="../assets/app-icon.png">
<link rel="stylesheet" href="../styles/forge-select.css">
<link rel="stylesheet" href="../assets/site.css">
<script type="application/ld+json">
Expand Down
Loading