Skip to content

refactor: commands - move the null exit code deprecation earlier#10112

Merged
paulbalandan merged 3 commits intocodeigniter4:4.8from
paulbalandan:move-deprecation-early
Apr 13, 2026
Merged

refactor: commands - move the null exit code deprecation earlier#10112
paulbalandan merged 3 commits intocodeigniter4:4.8from
paulbalandan:move-deprecation-early

Conversation

@paulbalandan
Copy link
Copy Markdown
Member

Description
Follow up to #10080

Moves the deprecation notice to the command runner (Commands) instead of in Boot where it will be only accessed by running spark commands directly in terminal. Uses in the command() function are not affected by the current deprecation. Thus, this PR fixes that.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@github-actions github-actions bot added the 4.8 PRs that target the `4.8` branch. label Apr 13, 2026
@paulbalandan paulbalandan added the refactor Pull requests that refactor code label Apr 13, 2026
@paulbalandan paulbalandan force-pushed the move-deprecation-early branch from cabff1e to 1e469bf Compare April 13, 2026 12:02
@paulbalandan paulbalandan merged commit 427fac0 into codeigniter4:4.8 Apr 13, 2026
64 of 66 checks passed
@paulbalandan paulbalandan deleted the move-deprecation-early branch April 13, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.8 PRs that target the `4.8` branch. refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants