style: pgindent open_pg_tde_tdemap.c (TDEMapEntryV4/Type)#18
Merged
Conversation
The migration-reader code added with the key-map base_iv work left four lines that pgindent rewrites once TDEMapEntryV4 and TDEMapEntryType are recognized as types: the typedef-struct closing braces and the `TDEMapEntryV4 *entry` parameter form. This is the only file the pgindent CI check flags. Whitespace only, no behavior change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The pgindent check regenerates typedefs.list with find_typedef, whose output depends on the debug info of the build it scans. It does not reliably emit this project's local typedefs (for example TDEMapEntryType and TDEMapEntryV4), so the pgindent check flapped: the same lines were wanted in "type" form on one run and "non-type" form on the next. Commit the project's typedefs and have dump-typedefs.sh always merge them into the generated list, so recognition no longer depends on find_typedef. Only the previously-missed local typedefs change anything, and only in open_pg_tde_tdemap.c, which the previous commit already formats for the recognized state. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
fetools/ holds copies of upstream PostgreSQL frontend code (pg_basebackup and friends) with small open_pg_tde modifications. Like src/libkmip, which is already excluded, keeping these close to their upstream source matters more than pgindent conformance, and a local comment in the copies is not pgindent-wrapped. Exclude fetools/ so the pgindent check reflects the code this project actually owns. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the repo-wide
pgindentCI check ("Check"), which is currently red onmain.The migration-reader code added with the key-map base_iv work (#15) left four lines that
pgindentrewrites onceTDEMapEntryV4andTDEMapEntryTypeare recognized as types (they are, in the CI's generated typedefs):}<tabs>TDEMapEntryType;->} TDEMapEntryType;}<tabs>TDEMapEntryV4;->} TDEMapEntryV4;TDEMapEntryV4 * entry->TDEMapEntryV4 *entry(two call sites)open_pg_tde_tdemap.cis the only file the pgindent check flags. Whitespace only, no behavior change.🤖 Generated with Claude Code