Use an RAII wrapper for stdio redirection#260
Merged
Mossaka merged 2 commits intocontainerd:mainfrom Aug 23, 2023
Merged
Conversation
jprendes
force-pushed
the
stdio
branch
2 times, most recently
from
394b86c to
439c34f
Compare
jsturtevant
reviewed
Aug 21, 2023
Contributor
There was a problem hiding this comment.
I put the sys folder up at the /src/ folder level in #238. thoughts on which level it should be on?
Mossaka
previously approved these changes
Aug 22, 2023
Member
|
Need a rebase |
Contributor
|
is #260 (comment) the location we want? otherwise lgtm |
Collaborator
Author
I'll fix that tomorrow. I'm AFK. |
jprendes
force-pushed
the
stdio
branch
2 times, most recently
from
4d249b0 to
cd56547
Compare
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Collaborator
Author
|
I moved the |
jprendes
force-pushed
the
stdio
branch
2 times, most recently
from
436c505 to
569f8e3
Compare
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Mossaka
approved these changes
Aug 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces an RAII wrapper to hande stdio redirection.
The wrapper handles the lifetime of the file descriptors involved.
It also introduces Windows support for stdio redirection.