B5/B18 docs and tests#113
Open
Lamarr3314 wants to merge 30 commits into
Open
Conversation
Owner
|
Overall looks good. Just address the maybe unintentional changes and then I can merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected 1 of the two factors missing in B5. The remaining value, MinNorm +2 ulp in BF_16 is prime and should be excluded from coverage in B18 and B5. B18 needs different factors for the lsb guard and sticky tests, B18 still reuses B18. Waiting on a helper overflow function.