Skip to content

🛡️ Sentinel: [security improvement] Add security headers to API responses #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crabcanon wants to merge 2 commits into
base: main
Choose a base branch
from
Open

🛡️ Sentinel: [security improvement] Add security headers to API responses #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
267da6a
🛡️ Sentinel: [security improvement] Add security headers to API respo…
google-labs-jules[bot] Jul 19, 2026
aa5ac8b
🛡️ Sentinel: [security improvement] Add security headers to API respo…
google-labs-jules[bot] Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .jules/sentinel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
## 2025-02-27 - Centralized Security Headers
**Vulnerability:** Missing default HTTP security headers (HSTS, X-Frame-Options, X-Content-Type-Options) in Cortex API responses.
**Learning:** Security headers should be injected globally via FastAPI middleware rather than on individual routes to ensure comprehensive coverage. The `request_context.py` middleware is the ideal centralized location for this. Care must be taken not to blindly add `Content-Security-Policy` with `default-src 'self'` as it may break API documentation UIs (Swagger/Redoc).
**Prevention:** Establish a pattern of checking for basic security headers during the initial setup of API gateway or edge middleware.
5 changes: 5 additions & 0 deletions apps/api/src/cortex_api/middleware/request_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,9 @@ async def request_context_middleware(
response.headers[X_REQUEST_ID_HEADER] = request_id
if trace_context["trace_id"]:
response.headers[X_TRACE_ID_HEADER] = str(trace_context["trace_id"])

response.headers["Strict-Transport-Security"] = "max-age=31536000; includeSubDomains"
response.headers["X-Frame-Options"] = "DENY"
response.headers["X-Content-Type-Options"] = "nosniff"

return response
Loading
Loading