Skip to content

Handle DAG runner agent creation failures per task #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cursor wants to merge 1 commit into
base: main
Choose a base branch
from
+24 −20
Draft

Handle DAG runner agent creation failures per task #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions .cursor/skills/dag-task-runner/scripts/run_dag.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,12 +337,7 @@ async function runTask(
? `${upstreamContext}\n\n---\n\n${task.subtask_prompt}`
: task.subtask_prompt;

const agent = await Agent.create({
apiKey: process.env.CURSOR_API_KEY!,
model: { id: ts.model },
local: { cwd },
});

let agent: Awaited<ReturnType<typeof Agent.create>> | undefined;
let run: RunnerTaskRun | undefined;
const buffer = new BoundedTextBuffer(STREAM_CAP);
let lastPublishAt = 0;
Expand All @@ -357,6 +352,11 @@ async function runTask(
const deadline = Date.now() + taskTimeoutMs;

try {
agent = await Agent.create({
apiKey: process.env.CURSOR_API_KEY!,
model: { id: ts.model },
local: { cwd },
});
run = (await agent.send(stitched)) as RunnerTaskRun;
const iterator = run.stream()[Symbol.asyncIterator]();
while (true) {
Expand Down Expand Up @@ -456,10 +456,12 @@ async function runTask(
await bestEffortCancel(run, task.id);
}
publishIfDue(true);
try {
await (agent as unknown as AsyncDisposable)[Symbol.asyncDispose]();
} catch {
// ignore dispose errors
if (agent) {
try {
await (agent as unknown as AsyncDisposable)[Symbol.asyncDispose]();
} catch {
// ignore dispose errors
}
}
writer.schedule(structuredCloneState(state));
}
Expand Down
22 changes: 12 additions & 10 deletions sdk/dag-task-runner/src/run_dag.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,12 +337,7 @@ async function runTask(
? `${upstreamContext}\n\n---\n\n${task.subtask_prompt}`
: task.subtask_prompt;

const agent = await Agent.create({
apiKey: process.env.CURSOR_API_KEY!,
model: { id: ts.model },
local: { cwd },
});

let agent: Awaited<ReturnType<typeof Agent.create>> | undefined;
let run: RunnerTaskRun | undefined;
const buffer = new BoundedTextBuffer(STREAM_CAP);
let lastPublishAt = 0;
Expand All @@ -357,6 +352,11 @@ async function runTask(
const deadline = Date.now() + taskTimeoutMs;

try {
agent = await Agent.create({
apiKey: process.env.CURSOR_API_KEY!,
model: { id: ts.model },
local: { cwd },
});
run = (await agent.send(stitched)) as RunnerTaskRun;
const iterator = run.stream()[Symbol.asyncIterator]();
while (true) {
Expand Down Expand Up @@ -456,10 +456,12 @@ async function runTask(
await bestEffortCancel(run, task.id);
}
publishIfDue(true);
try {
await (agent as unknown as AsyncDisposable)[Symbol.asyncDispose]();
} catch {
// ignore dispose errors
if (agent) {
try {
await (agent as unknown as AsyncDisposable)[Symbol.asyncDispose]();
} catch {
// ignore dispose errors
}
}
writer.schedule(structuredCloneState(state));
}
Expand Down