fix(ci): strictly filter GitHub Release assets by extension#75
Conversation
- The `actions/upload-artifact@v4` glob merges produced artifacts (including unpacked directories like `src-tauri` or `deb`). - Previously, the `release-artifacts/**` wildcard attempted to upload these directories or their loose contents to GitHub Releases, causing `Not Found` and upload errors. - Now strictly filtering to only upload actual installer extensions (`.AppImage`, `.deb`, `.dmg`, `.msi`, `.exe`, `.pkg.tar.zst`). - Bumped version to 0.1.0-beta.17 to trigger a clean release build.
There was a problem hiding this comment.
Pull request overview
This PR aims to make GitHub Release publishing more reliable by preventing the release workflow from attempting to upload unpacked artifact directories/loose files, restricting uploads to installer-like artifact extensions.
Changes:
- Restrict
.github/workflows/release.ymlrelease asset globs to specific file extensions (instead ofrelease-artifacts/**). - Bump
apps/desktop/package.jsonversion to0.1.0-beta.17.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apps/desktop/package.json | Updates the desktop app npm package version. |
| .github/workflows/release.yml | Narrows GitHub Release upload globs to avoid uploading directories/loose files from artifacts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { | ||
| "name": "desktop", | ||
| "version": "0.1.0-beta.16", | ||
| "version": "0.1.0-beta.17", |
There was a problem hiding this comment.
The PR bumps apps/desktop/package.json to 0.1.0-beta.17, but apps/desktop/src-tauri/tauri.conf.json and apps/desktop/src-tauri/Cargo.toml are still 0.1.0-beta.11, which creates version drift for local builds. Either update all three version sources together (per docs/releases.md guidance), or drop the package.json version bump from this CI-focused PR if it’s not intentional.
| "version": "0.1.0-beta.17", | |
| "version": "0.1.0-beta.11", |
| release-artifacts/**/*.AppImage | ||
| release-artifacts/**/*.deb | ||
| release-artifacts/**/*.rpm | ||
| release-artifacts/**/*.dmg |
There was a problem hiding this comment.
The PR description says release assets are filtered exclusively to .AppImage, .deb, .dmg, .msi, .exe, and .pkg.tar.zst, but the workflow also includes **/*.rpm. Please either update the PR description to include .rpm (if intended) or remove the .rpm glob to match the stated behavior.
The previous release job failed because the
softprops/action-gh-releasewas attempting to upload directories and loose files from the unpacked Tauri/makepkg artifacts (e.g.,src-tauri/ordeb/data/), which causedNot Founderrors.This PR restricts the uploaded files in
release.ymlexclusively to installer extensions (.AppImage,.deb,.dmg,.msi,.exe,.pkg.tar.zst), ensuring a clean and reliable release process without polluting the assets tab.