Skip to content

fix(ci): strictly filter GitHub Release assets by extension #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
d0dg3r merged 1 commit into from
Mar 24, 2026
Merged

fix(ci): strictly filter GitHub Release assets by extension #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,5 +362,11 @@ jobs:

**Marketing screenshots** (Flathub + Microsoft Store / Snap sizes): `marketing-screenshots.zip` in the assets below. Unzip and copy into `docs/media/screenshots/` if you want the repo to match the release visuals.
files: |
release-artifacts/**
release-artifacts/**/*.AppImage
release-artifacts/**/*.deb
release-artifacts/**/*.rpm
release-artifacts/**/*.dmg
Comment on lines +365 to +368
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description says release assets are filtered exclusively to .AppImage, .deb, .dmg, .msi, .exe, and .pkg.tar.zst, but the workflow also includes **/*.rpm. Please either update the PR description to include .rpm (if intended) or remove the .rpm glob to match the stated behavior.

Copilot uses AI. Check for mistakes.
release-artifacts/**/*.msi
release-artifacts/**/*.exe
release-artifacts/**/*.pkg.tar.zst
marketing-screenshots-artifact/marketing-screenshots.zip
2 changes: 1 addition & 1 deletion apps/desktop/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "desktop",
"version": "0.1.0-beta.16",
"version": "0.1.0-beta.17",
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR bumps apps/desktop/package.json to 0.1.0-beta.17, but apps/desktop/src-tauri/tauri.conf.json and apps/desktop/src-tauri/Cargo.toml are still 0.1.0-beta.11, which creates version drift for local builds. Either update all three version sources together (per docs/releases.md guidance), or drop the package.json version bump from this CI-focused PR if it’s not intentional.

Suggested change
"version": "0.1.0-beta.17",
"version": "0.1.0-beta.11",

Copilot uses AI. Check for mistakes.
"description": "Cross-platform SSH manager desktop app",
"scripts": {
"dev": "vite",
Expand Down
Loading