Add virtualization to DomainRankingsTable#8
Closed
Copilot wants to merge 2 commits into
Closed
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: dacs30 <60863302+dacs30@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add virtualization for ranking list rendering
Add virtualization to DomainRankingsTable
Feb 21, 2026
dacs30
requested changes
Feb 24, 2026
Owner
dacs30
left a comment
There was a problem hiding this comment.
Can we not use the current lib that was suggested?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rankings list renders all entries in the DOM simultaneously, causing unnecessary work as the list grows.
Changes
@tanstack/react-virtual: Added as dependency for windowed list rendering.DomainRankingsTable.tsx: Replacedrankings.map(...)in the full list section with a virtualized scroll container usinguseVirtualizer:max-h-[600px]scrollable container withparentReftranslateY(virtualRow.start)within a full-height inner divestimateSize: 56px,overscan: 5The top-3 podium section is unchanged — virtualization applies only to the scrollable full list below it.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.